Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_ndt_scan_matcher): fix cppcheck unusedFunction #9275

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Nov 9, 2024

Description

This is a fix based on cppcheck warning unusedFunction

localization/autoware_ndt_scan_matcher/src/ndt_omp/estimate_covariance.cpp:106:0: style: The function 'find_rotation_matrix_aligning_covariance_to_principal_axes' is never used. [unusedFunction]
Eigen::Matrix2d find_rotation_matrix_aligning_covariance_to_principal_axes(
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Nov 9, 2024
Copy link

github-actions bot commented Nov 9, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc self-assigned this Nov 9, 2024
@veqcc veqcc added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 9, 2024
@veqcc veqcc marked this pull request as ready for review November 9, 2024 09:19
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.25%. Comparing base (1ea45e6) to head (99c5777).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9275   +/-   ##
=======================================
  Coverage   29.24%   29.25%           
=======================================
  Files        1336     1336           
  Lines      102981   102986    +5     
  Branches    39958    39957    -1     
=======================================
+ Hits        30117    30126    +9     
+ Misses      69989    69984    -5     
- Partials     2875     2876    +1     
Flag Coverage Δ *Carryforward flag
differential 26.64% <ø> (?)
total 29.24% <ø> (+<0.01%) ⬆️ Carriedforward from 1ea45e6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@veqcc veqcc merged commit ac997e2 into autowarefoundation:main Nov 11, 2024
42 checks passed
@veqcc veqcc deleted the fix/cppcheck_unusedFunction2 branch November 11, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants