Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_pure_pursuit): fix cppcheck unusedFunction #9276

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Nov 9, 2024

Description

This is a fix based on cppcheck warning unusedFunction

control/autoware_pure_pursuit/src/autoware_pure_pursuit_core/planning_utils.cpp:168:0: style: The function 'isInPolygon' is never used. [unusedFunction]
bool isInPolygon(
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@veqcc veqcc self-assigned this Nov 9, 2024
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Nov 9, 2024
@veqcc veqcc added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Nov 9, 2024
Copy link

github-actions bot commented Nov 9, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.24%. Comparing base (1ea45e6) to head (01432ef).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9276   +/-   ##
=======================================
  Coverage   29.24%   29.24%           
=======================================
  Files        1336     1336           
  Lines      102981   102980    -1     
  Branches    39958    39952    -6     
=======================================
+ Hits        30117    30118    +1     
+ Misses      69989    69986    -3     
- Partials     2875     2876    +1     
Flag Coverage Δ *Carryforward flag
differential 30.64% <ø> (?)
total 29.25% <ø> (+<0.01%) ⬆️ Carriedforward from 1ea45e6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veqcc veqcc marked this pull request as ready for review November 9, 2024 09:53
@veqcc veqcc added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Nov 9, 2024
@veqcc veqcc merged commit c892b95 into autowarefoundation:main Nov 11, 2024
53 of 55 checks passed
@veqcc veqcc deleted the fix/cppcheck_unusedFunction3 branch November 11, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants