Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix packages with autoware_ prefix and keep code in autoware namespace #4569

Open
esteve opened this issue Mar 27, 2024 · 33 comments
Open
Assignees
Labels
component:system System design and integration.

Comments

@esteve
Copy link
Contributor

esteve commented Mar 27, 2024

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

See https://github.com/orgs/autowarefoundation/discussions/4097

Purpose

Keep Autoware code clearly separate from other projects by adding appropriate namespacing and prefixes

Possible approaches

Add autoware namespace and autoware_ prefix for package names

Definition of done

All packages are prefixed and the code is in the autoware namespace

List of packages in reverse topological order:

@xmfcx
Copy link
Contributor

xmfcx commented May 2, 2024

Following up from:

We should prefix the package folder names with autoware_ too.

The package name in the package.xml file should match its parent folder.

I might have missed something too, open to discussion.

@esteve
Copy link
Contributor Author

esteve commented May 2, 2024

@xmfcx I've been waiting for feedback from the TierIV engineers regarding renaming the folders. @mitsudome-r do you have any updates? Thanks.

@xmfcx
Copy link
Contributor

xmfcx commented May 2, 2024

I would like to change it and see the response in this case. And solve the issues after they arise.

main branch is a development branch and this is expected.

@mitsudome-r
Copy link
Member

I think we can move on with changing the package folder name as well.
However, we did have some concerns about the changing the package names & include folder structure for the packages in autoware_common repository and also the packages with tier4_ prefix.

https://github.com/autowarefoundation/autoware_common

@youtalk
Copy link
Member

youtalk commented Sep 3, 2024

@esteve Is it possible to prioritize renaming the packages under autoware.universe/common? In relation to #5077, we would like to complete the common packages first.

@esteve
Copy link
Contributor Author

esteve commented Sep 3, 2024

@youtalk yes, makes total sense to prioritize autoware.universe/common, I'll refocus on the remaining common packages.

@youtalk
Copy link
Member

youtalk commented Sep 3, 2024

@esteve Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration.
Projects
Status: In Progress
Development

No branches or pull requests

7 participants