Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(autoware_grid_map_utils): prefix folder structure with autoware/ #9170

Merged
merged 3 commits into from
Oct 29, 2024
Merged

refactor(autoware_grid_map_utils): prefix folder structure with autoware/ #9170

merged 3 commits into from
Oct 29, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Oct 28, 2024

Description

prefix folder structure with autoware/

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Oct 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve mentioned this pull request Oct 28, 2024
Open
46 tasks
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:require-cuda-build-and-test labels Oct 28, 2024
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 28, 2024
@esteve esteve marked this pull request as ready for review October 28, 2024 15:01
@esteve esteve self-assigned this Oct 28, 2024
takayuki5168
takayuki5168 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for planning

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.66%. Comparing base (4061041) to head (189eaac).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9170      +/-   ##
==========================================
- Coverage   28.67%   28.66%   -0.02%     
==========================================
  Files        1308     1313       +5     
  Lines      101361   101414      +53     
  Branches    39393    39397       +4     
==========================================
+ Hits        29063    29066       +3     
- Misses      69322    69370      +48     
- Partials     2976     2978       +2
Flag Coverage Δ *Carryforward flag
differential 20.21% <ø> (?)
total 28.67% <ø> (ø) Carriedforward from 4061041

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve enabled auto-merge (squash) October 29, 2024 11:53
@esteve
Copy link
Contributor Author

esteve commented Oct 29, 2024

@maxime-clem @takayuki5168 thank you for your reviews.

@xmfcx @mitsudome-r could you merge this PR when you have a moment? @maxime-clem is a code owner of this package and he approved the changes, so it should be find to merge. Thanks.

@xmfcx xmfcx disabled auto-merge October 29, 2024 11:57
@xmfcx xmfcx merged commit 9805f1f into autowarefoundation:main Oct 29, 2024
31 of 32 checks passed
@maxime-clem maxime-clem mentioned this pull request Oct 29, 2024
Merged
@esteve esteve deleted the prefix-autoware_grid_map_utils branch October 30, 2024 10:44
@esteve
Copy link
Contributor Author

esteve commented Oct 30, 2024

@xmfcx thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-clem maxime-clem maxime-clem approved these changes

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@mkquda mkquda Awaiting requested review from mkquda mkquda is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@yuki-takagi-66 yuki-takagi-66 Awaiting requested review from yuki-takagi-66 yuki-takagi-66 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@Shin-kyoto Shin-kyoto Awaiting requested review from Shin-kyoto Shin-kyoto is a code owner

Assignees

@esteve esteve

Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Sensing & Perception Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@esteve @takayuki5168 @maxime-clem @xmfcx