-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ekf_localizer)!: prefix package and namespace with autoware #8888
refactor(ekf_localizer)!: prefix package and namespace with autoware #8888
Conversation
Signed-off-by: a-maumau <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@a-maumau |
@SakodaShintaro I am sorry for that. It seems I overlooked some of the repository. |
@SakodaShintaro
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8888 +/- ##
==========================================
+ Coverage 27.92% 28.31% +0.38%
==========================================
Files 1324 1338 +14
Lines 98877 99587 +710
Branches 39821 40210 +389
==========================================
+ Hits 27615 28201 +586
- Misses 71210 71333 +123
- Partials 52 53 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: a-maumau <[email protected]>
3070c5c
to
0750dcf
Compare
Sorry for making PR comments little bit messy.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that logging_simulator
, planning_simulator
and e2e_simulator
with AWSIM works well.
I checked
-
Directory Name
- Add
autoware_
as a prefix to the directory name.
- Add
-
packages.xml
- Add
autoware_
to thename
element.
- Add
-
CMakeLists.txt
- Change the
project
name toautoware_***
. - Add
autoware::
toPLUGIN
.
- Change the
-
Header Files (.hpp)
- Add
autoware::
tonamespace
. - Add
autoware
folder as necessary and update include statements accordingly.
- Add
-
Source Files (.cpp)
- Add
autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.
- Add
-
Launch Files
- Add
autoware_
beforefind-pkg-share
. - Change
node pkg="<pkgname>"
toautoware_<pkgname>
.
- Add
-
Verification Points
- Search
find-pkg-share
in autoware - Check README file (especially json schema)
- Pay attention to complex cases like
sensor_launch
as seen ingnss_poser
- Search
LGTM
Description
This PR will add an autoware_ prefix to
ekf_localizer
package.Related links
autoware_tools: autowarefoundation/autoware_tools#119
Parent Issue:
How was this PR tested?
Checked with running the autoware sample-map.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.