Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: renamed the centerpoint config files #1061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Jul 9, 2024

reference: autowarefoundation/autoware.universe#7421

In the beforementioned PR, the config files for centerpoint had to be changed to comply with some schema rules
(For a particular schema file, all yaml files matching the base name were compared, which caused issues since centerpoint and centerpoint_tiny share the same base. Changing them to centerpoint_base and centerpoint_tiny_base resolved the problem).

This PR should be merged with the previous one simultaneously to avoid issues

…hen applying the new parameter schema

reference: autowarefoundation/autoware.universe#7421

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@miursh
Copy link
Contributor

miursh commented Jul 9, 2024

[Q] Do we need to change the names of the parameter files managed by TIER IV's ML packages as well?

@knzo25
Copy link
Contributor Author

knzo25 commented Jul 9, 2024

@miursh

If you refer to the *_ml_package.param.yaml files, they are unaffected by this change:

kenzolobos@SOME_PC_NAME:~/autoware_data/lidar_centerpoint$ ll
total 50456
drwxr-xr-x  2 kenzolobos kenzolobos     4096  4月 30 14:22 ./
drwxrwxr-x 18 kenzolobos kenzolobos     4096  4月 30 15:06 ../
-rw-r--r--  1 root       root            376  4月 26 20:25 centerpoint_ml_package.param.yaml
-rw-r--r--  1 root       root            374  4月 26 20:25 centerpoint_sigma_ml_package.param.yaml
-rw-r--r--  1 root       root            376  4月 26 20:25 centerpoint_tiny_ml_package.param.yaml

The files affected were the $(var model_name).param.yaml -> $(var model_name)_base.param.yaml,
which as far as I understand (correct me if I am wrong), are only in this repository and universe.

https://github.com/tby-udel/autoware.universe/blob/lidar-centerpoint-branch/perception/lidar_centerpoint/launch/lidar_centerpoint.launch.xml#L8-L9

In the companion PR, the only non-chema /documentation change beside file renaming is the following:
image

@knzo25
Copy link
Contributor Author

knzo25 commented Jul 9, 2024

Update: there was another instance where the previously mentioned change had to be applied. Asked the author of the related PR to reflect that.

Copy link

stale bot commented Sep 7, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants