Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update signal_processing downstream dependencies #110

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Sep 4, 2024

Description

This PR updates the packages that depend on signal_processing to now depend on autoware_signal_processing

Related links

autowarefoundation/autoware.universe#8541

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx
Copy link
Contributor

xmfcx commented Sep 20, 2024

I've rebased it to main to test with the latest changes.

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR, all the references to signal_processing package has been refactored.

Also tested with the planning sim demo.

@xmfcx xmfcx merged commit e6e8ce7 into autowarefoundation:main Sep 20, 2024
30 checks passed
@esteve esteve deleted the prefix-signal_processing branch September 25, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants