Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(signal_processing): prefix package and namespace with autoware #8541

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Aug 20, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 20, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Aug 20, 2024
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Aug 20, 2024
Copy link

github-actions bot commented Aug 20, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 28.03%. Comparing base (2a2d037) to head (9f4964f).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
..._obstacle_cruise_planner/src/planner_interface.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8541      +/-   ##
==========================================
+ Coverage   27.99%   28.03%   +0.04%     
==========================================
  Files        1319     1330      +11     
  Lines       98744    98935     +191     
  Branches    39802    39848      +46     
==========================================
+ Hits        27642    27741      +99     
- Misses      70948    71040      +92     
  Partials      154      154              
Flag Coverage Δ *Carryforward flag
differential 15.80% <0.00%> (?)
total 27.96% <ø> (-0.04%) ⬇️ Carriedforward from 2a2d037

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve enabled auto-merge (squash) August 21, 2024 07:11
@esteve esteve force-pushed the prefix-signal-processing branch 2 times, most recently from 48c4750 to 3f8852a Compare August 21, 2024 09:31
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request.
As for localization changes, it looks good to me.

Unfortunately, an error occurred during rosdep install.

vcs import src < tools.repos

and

+ rosdep install -y --from-paths src --ignore-src --rosdistro humble
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
driving_environment_analyzer: Cannot locate rosdep definition for [signal_processing]

Because there is a package that uses this signal_processing package in autoware_tools, please make the necessary changes.

@esteve
Copy link
Contributor Author

esteve commented Sep 4, 2024

@SakodaShintaro I've submitted autowarefoundation/autoware_tools#110, it should be merged after this PR is merged.

@SakodaShintaro
Copy link
Contributor

@esteve
Thank you for creating a pull request for autoware_tools.
Could you resolve the conflict in this pull request?

@esteve
Copy link
Contributor Author

esteve commented Sep 18, 2024

@mitsudome-r @xmfcx I've fixed the conflicts again, could you approve this PR when you can? Thanks

@xmfcx
Copy link
Contributor

xmfcx commented Sep 19, 2024

I'll rebase to main to test it with the latest autoware.

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to compile and run planning simulator with this PR.

@xmfcx xmfcx disabled auto-merge September 20, 2024 08:46
@xmfcx xmfcx merged commit fc283c5 into autowarefoundation:main Sep 20, 2024
31 of 32 checks passed
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants