-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(signal_processing): prefix package and namespace with autoware #8541
refactor(signal_processing): prefix package and namespace with autoware #8541
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8541 +/- ##
==========================================
+ Coverage 27.99% 28.03% +0.04%
==========================================
Files 1319 1330 +11
Lines 98744 98935 +191
Branches 39802 39848 +46
==========================================
+ Hits 27642 27741 +99
- Misses 70948 71040 +92
Partials 154 154
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
48c4750
to
3f8852a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request.
As for localization changes, it looks good to me.
Unfortunately, an error occurred during rosdep install.
vcs import src < tools.repos
and
+ rosdep install -y --from-paths src --ignore-src --rosdistro humble
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
driving_environment_analyzer: Cannot locate rosdep definition for [signal_processing]
Because there is a package that uses this signal_processing package in autoware_tools, please make the necessary changes.
3f8852a
to
1695bbb
Compare
@SakodaShintaro I've submitted autowarefoundation/autoware_tools#110, it should be merged after this PR is merged. |
@esteve |
1695bbb
to
8ac90eb
Compare
@mitsudome-r @xmfcx I've fixed the conflicts again, could you approve this PR when you can? Thanks |
I'll rebase to main to test it with the latest autoware. |
Signed-off-by: Esteve Fernandez <[email protected]>
8ac90eb
to
9f4964f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to compile and run planning simulator with this PR.
…re (autowarefoundation#8541) Signed-off-by: Esteve Fernandez <[email protected]> Signed-off-by: Batuhan Beytekin <[email protected]>
Description
prefix package and namespace with autoware
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.