Skip to content

Feature: alias close_modal action response to do_nothing #2394

Feature: alias close_modal action response to do_nothing

Feature: alias close_modal action response to do_nothing #2394

Status Failure
Total duration 44s
Artifacts

lint.yml

on: pull_request
lint  /  ...  /  standardrb
32s
lint / runner / standardrb
lint  /  ...  /  erb-lint
7s
lint / runner / erb-lint
lint  /  check-eslint-config
3s
lint / check-eslint-config
lint  /  ...  /  eslint
0s
lint / runner / eslint
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 2 warnings
lint / runner / standardrb: lib/avo/base_action.rb#L241
[rubocop] reported by reviewdog 🐶 [Corrected] Style/Alias: Use alias_method instead of alias. Raw Output: lib/avo/base_action.rb:241:5: C: [Corrected] Style/Alias: Use alias_method instead of alias. alias do_nothing close_modal ^^^^^
lint / runner / standardrb: spec/system/avo/actions_spec.rb#L182
[rubocop] reported by reviewdog 🐶 [Corrected] Layout/EmptyLines: Extra blank line detected. Raw Output: spec/system/avo/actions_spec.rb:182:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
lint / runner / standardrb: spec/system/avo/actions_spec.rb#L192
[rubocop] reported by reviewdog 🐶 [Corrected] Layout/EmptyLines: Extra blank line detected. Raw Output: spec/system/avo/actions_spec.rb:192:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected.
lint / runner / standardrb: spec/system/avo/actions_spec.rb#L195
[rubocop] reported by reviewdog 🐶 [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. Raw Output: spec/system/avo/actions_spec.rb:195:32: C: [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. expect(page).to have_css('turbo-frame#actions_show') ^^^^^^^^^^^^^^^^^^^^^^^^^^
lint / runner / standardrb: spec/system/avo/actions_spec.rb#L200
[rubocop] reported by reviewdog 🐶 [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. Raw Output: spec/system/avo/actions_spec.rb:200:34: C: [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. expect(page).to have_field('user_first_name', with: 'First name should persist after action.') ^^^^^^^^^^^^^^^^^
lint / runner / standardrb: spec/system/avo/actions_spec.rb#L200
[rubocop] reported by reviewdog 🐶 [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. Raw Output: spec/system/avo/actions_spec.rb:200:59: C: [Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. expect(page).to have_field('user_first_name', with: 'First name should persist after action.') ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lint / check-eslint-config
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
lint / check-eslint-config
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/