Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: display backtrace on unrelated form errors #2905

Merged
merged 12 commits into from
Jun 28, 2024

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Jun 28, 2024

Description

Fixes #2856
Fixes #2691
Docs https://docs.avohq.io/3.0/authentication.html#user-roles

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

CleanShot 2024-06-28 at 17 17 48@2x

Manual review steps

  1. Go to course.rb model
  2. remove the if conditional from the after_save callback
  3. try to update a course
  4. you should see the trace in the UI

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Jun 28, 2024

Code Climate has analyzed commit 03f235c and detected 0 issues on this pull request.

View more on Code Climate.

lib/avo/current.rb Outdated Show resolved Hide resolved
lib/avo/current.rb Outdated Show resolved Hide resolved
spec/dummy/app/models/course.rb Outdated Show resolved Hide resolved
spec/dummy/app/models/course.rb Outdated Show resolved Hide resolved
…ithub.com:avo-hq/avo into enhancement/display-backtrace-of-unrelated-errors
spec/dummy/app/models/course.rb Outdated Show resolved Hide resolved
spec/system/avo/alert_backtrace_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/alert_backtrace_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/alert_backtrace_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/alert_backtrace_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/alert_backtrace_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/alert_backtrace_spec.rb Outdated Show resolved Hide resolved
@adrianthedev adrianthedev merged commit b805ab6 into main Jun 28, 2024
1 check passed
@adrianthedev adrianthedev deleted the enhancement/display-backtrace-of-unrelated-errors branch June 28, 2024 20:25
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Experience (DX) Enhancement Not necessarily a feature, but something has improved
Projects
None yet
1 participant