Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix bad validation test #2915

Merged
merged 3 commits into from
Jun 30, 2024
Merged

test: fix bad validation test #2915

merged 3 commits into from
Jun 30, 2024

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes a spec that somehow passed un-noticed.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copy link

codeclimate bot commented Jun 30, 2024

Code Climate has analyzed commit cba9bf5 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev
Copy link
Collaborator Author

This PR also adds a monkeypatch to make ferrum render the page properly in the browser.

rubycdp/cuprite#269 (comment)

@github-actions github-actions bot added the test label Jun 30, 2024
spec/rails_helper.rb Outdated Show resolved Hide resolved
spec/rails_helper.rb Outdated Show resolved Hide resolved
spec/rails_helper.rb Outdated Show resolved Hide resolved
spec/rails_helper.rb Outdated Show resolved Hide resolved
spec/rails_helper.rb Outdated Show resolved Hide resolved
spec/rails_helper.rb Outdated Show resolved Hide resolved
spec/rails_helper.rb Outdated Show resolved Hide resolved
spec/rails_helper.rb Outdated Show resolved Hide resolved
spec/rails_helper.rb Outdated Show resolved Hide resolved
@adrianthedev adrianthedev merged commit 5cf66f5 into main Jun 30, 2024
27 checks passed
@adrianthedev adrianthedev deleted the test/fix-bad-spec branch June 30, 2024 18:38
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant