refactor: Prefer Model.reflections over private Model#_reflections. #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `_reflections` returns different key type per Rails version
|
@Paul-Bob please review this and it works, let's ship it for 2.0! We should check out if we can port it to 3.0 as well. |
|
I can update also to |
|
OK. let's retry that one then. Maybe it works on your end! |
|
This PR has been marked as stale because there was no activity for the past 15 days. |
Made this PR for version 3 that replace |
simi
changed the title
|
@Paul-Bob updated, I tried to keep changes minimal. Specs seems happy. |
adrianthedev
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 This targets 2.x branch.
_reflectionsreturns different key type per Rails versionℹ️ Model.reflections seems supported for 6.0+ (I have not checked earlier versions since those seems unsupported).
💡 This fixes issues at RubyGems.org with Rails 7.2 beta compatibility.