Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage CI after push to master #5958

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

richtja
Copy link
Contributor

@richtja richtja commented Jun 17, 2024

This commit adds the coverage CI job to a workflow which will be triggered on PR and after the push to the main branches LTS and master. This is needed because codeclimate needs coverage date from master to show the proper results.

This commit adds the coverage CI job to a workflow which will be
triggered on PR and after the push to the main branches `LTS` and
`master`. This is needed because codeclimate needs coverage date from
master to show the proper results.

Signed-off-by: Jan Richter <[email protected]>
@richtja richtja requested a review from clebergnu June 17, 2024 12:03
@richtja richtja self-assigned this Jun 17, 2024
@richtja richtja requested a review from harvey0100 June 17, 2024 12:49
Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor comment/reminder, LGTM.

runs-on: ubuntu-20.04

strategy:
matrix:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you're just moving code from different files, but we need to look into this "matrix of a single element" here on the side. Just a reminder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUIC this is needed for, reusing the python-version variable. We have this on couple of other places, like in here.

@richtja richtja merged commit d752cb2 into avocado-framework:master Jun 18, 2024
58 checks passed
@richtja richtja deleted the coverage_in_master branch October 9, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants