Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage CI after push to master #5958

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Coverage CI after push to master #5958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,39 +105,6 @@ jobs:
retention-days: 1
- run: echo "🥑 This job's status is ${{ job.status }}."

code-coverage:

name: Code Coverage
runs-on: ubuntu-20.04

strategy:
matrix:
python-version: [3.11]
env:
CC_TEST_REPORTER_ID: "387887b88a76f31c2c376219fc749689ea5975c8fe7fcd9609f1dcc139e053a6"

steps:
- run: echo "Job triggered by a ${{ github.event_name }} event on branch is ${{ github.ref }} in repository is ${{ github.repository }}, runner on ${{ runner.os }}"
- name: Check out repository code
uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Install
run: |
pip install -r requirements-dev.txt
curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
chmod +x ./cc-test-reporter
- name: Run pre script
run: ./cc-test-reporter before-build
- name: Run script
run: |
python setup.py develop --user
./selftests/run_coverage
- name: Run post script
run: ./cc-test-reporter after-build --debug
- run: echo "🥑 This job's status is ${{ job.status }}."


# macOS check on latest Python
Expand Down
36 changes: 35 additions & 1 deletion .github/workflows/codeql.yml → .github/workflows/push_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "CodeQL"
name: "PR and Push checks"

on:
push:
Expand Down Expand Up @@ -69,3 +69,37 @@ jobs:
uses: github/codeql-action/analyze@v3
with:
category: "/language:${{matrix.language}}"

code-coverage:

name: Code Coverage
runs-on: ubuntu-20.04

strategy:
matrix:
python-version: [3.11]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you're just moving code from different files, but we need to look into this "matrix of a single element" here on the side. Just a reminder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUIC this is needed for, reusing the python-version variable. We have this on couple of other places, like in here.

env:
CC_TEST_REPORTER_ID: "387887b88a76f31c2c376219fc749689ea5975c8fe7fcd9609f1dcc139e053a6"

steps:
- run: echo "Job triggered by a ${{ github.event_name }} event on branch is ${{ github.ref }} in repository is ${{ github.repository }}, runner on ${{ runner.os }}"
- name: Check out repository code
uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Install
run: |
pip install -r requirements-dev.txt
curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
chmod +x ./cc-test-reporter
- name: Run pre script
run: ./cc-test-reporter before-build
- name: Run script
run: |
python setup.py develop --user
./selftests/run_coverage
- name: Run post script
run: ./cc-test-reporter after-build --debug
- run: echo "🥑 This job's status is ${{ job.status }}."
Loading