chore: upgrade jest to 29 #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stocaaro
previously approved these changes
Aug 12, 2024
| @@ -4,7 +4,7 @@ import { sleep } from './sleep'; | |||
| const defaultSettings: RetrySettings = { | |||
| times: Infinity, | |||
| delayMS: 1000 * 10, // 10 seconds | |||
| timeoutMS: 1000 * 60 * 20, // 20 minutes | |||
| timeoutMS: 1000 * 60 * 25, // 25 minutes | |||
There was a problem hiding this comment.
What did you encounter that caused the bump from 20 to 25 minutes on the timeout?
I would guess this means our e2e tests slowed down by ~25%, which might be enough to be worth an investigation. If you have already done the investigation, whats driving the increase and can we do better?
There was a problem hiding this comment.
There is a performance degradation with newer versions of Jest when run with node < 20 (jestjs/jest#11956). We currently support Node 18. Node 18 will be EOL in 8 months, so we should look into upgrading to Node 20.
dpilch
force-pushed
the
jest-upgrade
branch
2 times, most recently
from
0baca8c to
9d262d6
Compare
dpilch
force-pushed
the
jest-upgrade
branch
8 times, most recently
from
0abd8c3 to
9d36991
Compare
dpilch
commented
Aug 29, 2024
| @@ -6,7 +6,6 @@ env: | |||
| AMPLIFY_PATH: /root/.npm-global/lib/node_modules/@aws-amplify/cli-internal/bin/amplify | |||
| CI: true | |||
| CODEBUILD: true | |||
| NODE_OPTIONS: --max-old-space-size=8096 | |||
palpatim
reviewed
Aug 30, 2024
palpatim
approved these changes
Aug 30, 2024
phani-srikar
approved these changes
Aug 30, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Upgrade Jest to 29. This is necessary to upgrade amplify-backend packages to GA versions.
jest.setTimeout()is ignored if run async'ly inbeforeAll()hook jestjs/jest#9359BUILD_GENERAL1_LARGEand single test instances are usingBUILD_GENERAL1_MEDIUM.CDK / CloudFormation Parameters Changed
N/A
Issue #, if available
#2741
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.