-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade jest to 29 #2747
Changes from 24 commits
3770c1f
04edf59
e516dce
61d78f3
3b36683
0973633
ded0cbb
163ff7d
7e40b10
6c4c044
d11d392
072d7ea
181662a
7cd733d
0ad5bf6
f0c466f
f3bac70
3f2bf5b
5f14bda
34c8148
d88912b
34a945e
49ab1e0
049e015
160d3bb
421f754
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ import { sleep } from './sleep'; | |
const defaultSettings: RetrySettings = { | ||
times: Infinity, | ||
delayMS: 1000 * 10, // 10 seconds | ||
timeoutMS: 1000 * 60 * 20, // 20 minutes | ||
timeoutMS: 1000 * 60 * 25, // 25 minutes | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What did you encounter that caused the bump from 20 to 25 minutes on the timeout? I would guess this means our e2e tests slowed down by ~25%, which might be enough to be worth an investigation. If you have already done the investigation, whats driving the increase and can we do better? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a performance degradation with newer versions of Jest when run with node < 20 (jestjs/jest#11956). We currently support Node 18. Node 18 will be EOL in 8 months, so we should look into upgrading to Node 20. |
||
stopOnError: true, // terminate the retries if a func calls throws an exception | ||
}; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were ignored.