fix(data): update datastore-storage-adapter subpaths #12801 #13083
Conversation
|
Please ensure that this PR:
A repository administrator is required to review & merge this change. |
david-mcafee
changed the title
packages/aws-amplify/package.json
Outdated
| @@ -53,6 +53,12 @@ | |||
| "require": "./dist/cjs/datastore/index.js", | |||
| "react-native": "./src/datastore/index.ts" | |||
| }, | |||
| "./datastore-storage-adapter": { | |||
There was a problem hiding this comment.
I'm a bit confused by this, datastore-storage-adapter isn't a dependency of aws-amplify so why are we vending a new export path for it? Is this related to the xml2js change? Will this change how customers need to use datastore-storage-adapter? Blocking PR just to be safe as this will change the export surface of the library.
david-mcafee
dismissed stale reviews from iartemiev, svidgen, and stocaaro
via
3183f43
There was a problem hiding this comment.
We also need to add the new shim files to your files list in the package.json for them to get distributed to NPM. I'd recommend testing in Verdaccio with React + RN to make sure all the import paths are usable.
Storage example: https://github.com/aws-amplify/amplify-js/blob/main/packages/storage/package.json#L61
| @@ -43,5 +43,13 @@ | |||
| "react-native-sqlite-storage": "5.0.0", | |||
| "sqlite3": "^5.0.2", | |||
| "typescript": "5.0.2" | |||
| }, | |||
| "exports": { | |||
| ".": { | |||
There was a problem hiding this comment.
Missing the RN entry point looks like?
|
This looks to have gone stale. Any update here? Be great to get #12801 fixed. |
Description of changes
fix(data): update datastore-storage-adapter subpaths
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.