Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): update datastore-storage-adapter subpaths #12801 #13083

Closed
wants to merge 9 commits into from
Closed

fix(data): update datastore-storage-adapter subpaths #12801 #13083

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f871d71
fix(data): update datastore-storage-adapter subpaths
david-mcafee Mar 5, 2024
389cb1d
run against E2E tests
david-mcafee Mar 5, 2024
01bfd83
empty commit
david-mcafee Mar 5, 2024
7ce5f04
empty commit
david-mcafee Mar 5, 2024
1f7b01f
revert temp config to run tests in pipeline
david-mcafee Mar 5, 2024
3183f43
subpath update
david-mcafee Mar 5, 2024
5b2bded
add additional package.json
david-mcafee Mar 5, 2024
2e41421
remove top-level package.json
david-mcafee Mar 5, 2024
456f28c
add shim files
david-mcafee Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/aws-amplify/datastore-storage-adapter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"name": "aws-amplify/datastore-storage-adapter",
"main": "../dist/cjs/datastore-storage-adapter/index.js",
"react-native": "../src/datastore-storage-adapter/index.ts",
"browser": "../dist/esm/datastore-storage-adapter/index.mjs",
"module": "../dist/esm/datastore-storage-adapter/index.mjs",
"typings": "../dist/esm/datastore-storage-adapter/index.d.ts"
}
6 changes: 6 additions & 0 deletions packages/aws-amplify/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@
"require": "./dist/cjs/datastore/index.js",
"react-native": "./src/datastore/index.ts"
},
"./datastore-storage-adapter": {
Copy link
Contributor

@jimblanc jimblanc Mar 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by this, datastore-storage-adapter isn't a dependency of aws-amplify so why are we vending a new export path for it? Is this related to the xml2js change? Will this change how customers need to use datastore-storage-adapter? Blocking PR just to be safe as this will change the export surface of the library.

"types": "./dist/esm/datastore-storage-adapter/index.d.ts",
"import": "./dist/esm/datastore-storage-adapter/index.mjs",
"require": "./dist/cjs/datastore-storage-adapter/index.js",
"react-native": "./src/datastore-storage-adapter/index.ts"
},
"./auth/cognito": {
"types": "./dist/esm/auth/cognito/index.d.ts",
"import": "./dist/esm/auth/cognito/index.mjs",
Expand Down
Loading