Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): remove esm for watch modes from onboarding guidelines #13442

Merged
merged 4 commits into from
May 29, 2024

Conversation

joon-won
Copy link
Member

Description of changes

  • Update Contributing Guidelines to replace deprecated yarn build:esm:watch with yarn build:watch for Watch mode.

Issue #, if available

Description of how you validated changes

  • yarn build:esm:watch was removed from packages.json back in January 29, 2024 with commit hash dd497d0ca6ef53906bff56a104ebd81c7b7d94bb and it is not longer available.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joon-won joon-won requested review from a team as code owners May 28, 2024 22:46
Copy link
Member

@ashika112 ashika112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashika112 ashika112 merged commit 8b95a2d into aws-amplify:main May 29, 2024
30 checks passed
@joon-won joon-won deleted the joonwonc/chore-remove-esm branch May 29, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants