Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): remove esm for watch modes from onboarding guidelines #13442

Merged
merged 4 commits into from
May 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,15 @@ Run watch mode while editing (auth for example):

```
npx lerna exec --scope @aws-amplify/auth yarn link
npx lerna exec --scope @aws-amplify/auth yarn build:esm:watch
npx lerna exec --scope @aws-amplify/auth yarn build:watch
```

Or run the whole library in watch mode if you are working on multiple packages

```
yarn build # Build the whole library
yarn link-all # Make all the packages available to link
yarn build:esm:watch # All packages are building ES6 modules in watch mode
yarn build:watch # All packages are building in watch mode
```

In your sample project, you can now link specific packages
Expand Down
4 changes: 2 additions & 2 deletions packages/datastore/docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@

## Testing DataStore changes locally
- On first build:
- Within **amplify-js**: `yarn && yarn build && yarn link-all && yarn build:esm:watch`
- Within **amplify-js**: `yarn && yarn build && yarn link-all && yarn build:watch`
- Within sample app: `yarn && yarn link aws-amplify && yarn link @aws-amplify/datastore && yarn start`
- On subsequent builds (useful if something isn't working):
- Within **amplify-js**: `yarn clean && yarn build && yarn link-all && yarn build:esm:watch`
- Within **amplify-js**: `yarn clean && yarn build && yarn link-all && yarn build:watch`
- Within sample app: `rm -rf node_modules && yarn && yarn link aws-amplify && yarn link @aws-amplify/datastore && yarn start`

## Contributing to these docs
Expand Down
Loading