fix(core): Check for storage initialization errors #13938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwomack
requested review from
haverchuck,
cshfang,
jimblanc,
HuiSF and
a team
as code owners
HuiSF
reviewed
Oct 18, 2024
HuiSF
previously approved these changes
Oct 18, 2024
jimblanc
approved these changes
Oct 18, 2024
ashika112
reviewed
Oct 31, 2024
| @@ -5,7 +5,6 @@ | |||
| /* eslint-disable camelcase */ | |||
|
|
|||
| /* Does not like exhaustive checks */ | |||
| /* eslint-disable no-case-declarations */ | |||
There was a problem hiding this comment.
this was from running yarn lint:fix on core
ashika112
previously approved these changes
Oct 31, 2024
ashika112
previously approved these changes
Oct 31, 2024
AllanZhengYP
reviewed
Nov 1, 2024
Co-authored-by: AllanZhengYP <[email protected]>
ashika112
approved these changes
Nov 7, 2024
AllanZhengYP
reviewed
Nov 8, 2024
| ? window.localStorage | ||
| : new InMemoryStorage(); | ||
|
|
||
| const logger = new ConsoleLogger('CoreStorageUtils'); |
There was a problem hiding this comment.
I dont' think we have a convention for logger name but this looks good to me!
AllanZhengYP
approved these changes
Nov 8, 2024
pranavosu
approved these changes
Nov 8, 2024
3 tasks
yuhengshs
added a commit
that referenced
this pull request
Nov 13, 2024
This reverts commit 0f50917.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added Session Storage and Default Storage try catch blocks
Issue #, if available
Resolves #13747
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.