-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Check for storage initialization errors #13938
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3e3c873
fix(core): Check for storage initialization errors
cwomack 1c75dbe
address nits and add logger
cwomack 39353ac
fixed unit test errors
cwomack 7490efc
bundle size fixes
cwomack 26c6f18
Merge branch 'main' into fix/storage-init-errors
cwomack 8bec1bf
implementing feedback
cwomack 8bdf691
Merge branch 'main' into fix/storage-init-errors
cwomack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,51 @@ | ||
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
import { ConsoleLogger } from '../Logger'; | ||
|
||
import { InMemoryStorage } from './InMemoryStorage'; | ||
|
||
/** | ||
* @internal | ||
* @returns Either a reference to window.localStorage or an in-memory storage as fallback | ||
*/ | ||
export const getLocalStorageWithFallback = (): Storage => | ||
typeof window !== 'undefined' && window.localStorage | ||
? window.localStorage | ||
: new InMemoryStorage(); | ||
|
||
const logger = new ConsoleLogger('CoreStorageUtils'); | ||
|
||
export const getLocalStorageWithFallback = (): Storage => { | ||
try { | ||
// Attempt to use localStorage directly | ||
if (typeof window !== 'undefined' && window.localStorage) { | ||
return window.localStorage; | ||
cwomack marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
} catch (e) { | ||
// Handle any errors related to localStorage access | ||
logger.error('LocalStorage access failed:', e); | ||
} | ||
|
||
// Return in-memory storage as a fallback if localStorage is not accessible | ||
return new InMemoryStorage(); | ||
}; | ||
|
||
/** | ||
* @internal | ||
* @returns Either a reference to window.sessionStorage or an in-memory storage as fallback | ||
*/ | ||
export const getSessionStorageWithFallback = (): Storage => | ||
typeof window !== 'undefined' && window.sessionStorage | ||
? window.sessionStorage | ||
: new InMemoryStorage(); | ||
export const getSessionStorageWithFallback = (): Storage => { | ||
try { | ||
// Attempt to use sessionStorage directly | ||
if (typeof window !== 'undefined' && window.sessionStorage) { | ||
// Verify we can actually use it by testing access | ||
window.sessionStorage.getItem('test'); | ||
|
||
return window.sessionStorage; | ||
} | ||
|
||
throw new Error('sessionStorage is not defined'); | ||
} catch (e) { | ||
// Handle any errors related to sessionStorage access | ||
logger.error('SessionStorage access failed:', e); | ||
|
||
return new InMemoryStorage(); | ||
} | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont' think we have a convention for logger name but this looks good to me!