Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address dafny-lang/dafny#2500 #599

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

texastony
Copy link
Contributor

@texastony texastony commented Jul 27, 2022

Issue #, if available: dafny-lang/dafny#2500

Description of changes:

  1. Update PR template so future work continues to respect {:termination false} also allows incorrect implementations of trait functions dafny-lang/dafny#2500
  2. I also audited the ESDK-Dafny, validating that all the trait specifications are copied onto classes that extend them.

Squash/merge commit message, if applicable: chore: address dafny-lang/dafny#2500

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Due to dafny-lang/dafny#2500, Traits are dangerous:

  1. Does this PR add any traits or classes that extend a trait?
  2. Are these traits annotated with {:termination false}?

The override checks on
the specifications on
a class' functions/methods/etc. validating
that specifications are
at least as strong as those on
the traits it implements
are not working correctly when
that trait is defined in a different module
(and hence must have {:termination false} on it).

As such, if either (1.) or (2.) is true:

  • manually verified all the trait specifications are copied onto classes that extend them?

@texastony texastony requested a review from a team as a code owner July 27, 2022 20:40
@texastony texastony marked this pull request as draft July 27, 2022 20:40
@texastony texastony marked this pull request as ready for review July 27, 2022 20:45
Copy link
Contributor

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lack of a mechanism makes me sad, but this is a good temporary measure.

@texastony texastony merged commit 686d34b into aws:mainline Jul 27, 2022
josecorella pushed a commit that referenced this pull request Oct 11, 2023
@texastony texastony deleted the dafny-issue-2500 branch November 29, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants