Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: address dafny-lang/dafny#2500 #599

Merged
merged 3 commits into from
Jul 27, 2022
Merged

chore: address dafny-lang/dafny#2500 #599

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2bea22
chore: address dafny-lang/dafny#2500
texastony Jul 27, 2022
588a774
fix: typos and formatting
texastony Jul 27, 2022
5b0d1a9
fix: formatting
texastony Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,20 @@


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

# Due to [dafny-lang/dafny#2500](https://github.com/dafny-lang/dafny/issues/2500), Traits are dangerous:
1. [ ] Does this PR add any traits or classes that extend a trait?
2. [ ] Are these traits annotated with `{:termination false}`?

The override checks on
the specifications on
a class' functions/methods/etc. validating
that specifications are
at least as strong as those on
the traits it implements
are not working correctly when
that trait is defined in a different module
(and hence must have `{:termination false}` on it).

As such, if either (1.) or (2.) is true:
- [ ] manually verified all the trait specifications are copied onto classes that extend them?