Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Vendor serverlessrepo to remove dependency #5572

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

mildaniel
Copy link
Contributor

Which issue(s) does this change fix?

#5569

Why is this change necessary?

To remove our dependency on serverlessrepo which is an archived project that is no longer being updated, and is causing issues because of its outdated dependencies.

How does it address the issue?

Vendors the components of serverlessrepo that AWS SAM CLI uses.

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mildaniel mildaniel requested a review from a team as a code owner July 19, 2023 19:19
@github-actions github-actions bot added area/publish sam publish command pr/internal labels Jul 19, 2023
@mildaniel mildaniel added this pull request to the merge queue Jul 19, 2023
Merged via the queue into aws:develop with commit 44c98ab Jul 19, 2023
75 checks passed
@mildaniel mildaniel deleted the vendor-serverlessrepo branch July 19, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/publish sam publish command pr/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants