Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(endpoint): enable test for s3 empty arn type #6379

Closed
wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 12, 2024

Issue

Internal JS-5234

Description

Enables test for s3 empty arn type

Testing

ToDo


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Member Author

trivikr commented Aug 12, 2024

Log of the failing test

$ yarn jest -c tests/endpoints-2.0/jest.config.js tests/endpoints-2.0/endpoints-integration.spec.ts
...
  ● client list › client-s3 endpoint test cases › empty arn type

    expect(received).toContain(expected) // indexOf

    Expected substring: "Invalid ARN: No ARN type specified"
    Received string:    "EndpointError: Invalid ARN: arn:aws:not-s3:us-west-2:123456789012::myendpoint was not a valid ARN"

      84 |               expect(observedError).not.toBeUndefined();
      85 |               expect(observedError?.url).toBeUndefined();
    > 86 |               expect(normalizeQuotes(String(observedError))).toContain(normalizeQuotes(error));
         |                                                              ^
      87 |             }
      88 |           }
      89 |         });

@trivikr
Copy link
Member Author

trivikr commented Aug 12, 2024

Superceded by #6380

@trivikr trivikr closed this Aug 12, 2024
@trivikr trivikr deleted the test-endpoints-s3-empty-arn-type branch August 12, 2024 23:30
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant