Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util-endpoints): check for entire resource-path being empty #6380

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 12, 2024

Issue

Refs: #6379 (comment)

Description

Check for entire resource-path being empty when parsing Arn

Testing

Unit and Endpoint tests are successful

$ yarn jest -c tests/endpoints-2.0/jest.config.js tests/endpoints-2.0/endpoints-integration.spec.ts
...
Test Suites: 1 passed, 1 total
Tests:       14672 passed, 14672 total

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…both delimiters

This reverts commit 855f1fa.
It'll be added, if needed, in a separate PR.
Copy link
Contributor

@gosar gosar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to ship this to unblock failing test, but follow up on expected behavior for case like arn:aws:s3:us-west-2:123456789012:my:folder/my:file

@trivikr trivikr merged commit 08ad510 into aws:main Aug 13, 2024
5 checks passed
@trivikr trivikr deleted the fix-parse-arn-resource-id branch August 13, 2024 19:24
@trivikr
Copy link
Member Author

trivikr commented Aug 14, 2024

follow up on expected behavior for case like arn:aws:s3:us-west-2:123456789012:my:folder/my:file

PR #6387

Copy link

github-actions bot commented Sep 2, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants