Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amazonq): Enable implicit @workspace context for Amzn users #5856

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

leigaol
Copy link
Contributor

@leigaol leigaol commented Oct 24, 2024

Problem

The chat workspace context requires user to manually input @workspace in the chat window, but when user do not have such prompt, workspace context can still be useful, we want to always send the relevant document and let service decide when to utilize it.

Solution

Enable implicit @workspace context for Amzn users. For these users, if they do not have @workspace in the chat prompt, the relevantTextDocument is still added to the chat API. This will be AB tested

This PR also removes the outdated data collection experiment


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested review from a team as code owners October 24, 2024 18:26
@leigaol leigaol marked this pull request as draft October 24, 2024 18:26
Copy link

This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@leigaol leigaol marked this pull request as ready for review November 12, 2024 22:48
@@ -0,0 +1,4 @@
{
"type": "Feature",
"description": "Enable default `@workspace` context of Amazon Q chat for certain users"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's not for public users to access this feature, i think we probably dont want to mention it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it is still customer facing

@Will-ShaoHua Will-ShaoHua self-requested a review November 12, 2024 23:21
@justinmk3 justinmk3 merged commit 4235561 into aws:master Nov 13, 2024
40 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants