Skip to content
golangci-lint

Add in-place upgrade controllers for kcp and md #23181

Sign in to view logs

Add in-place upgrade controllers for kcp and md

Add in-place upgrade controllers for kcp and md #23181

Triggered via pull request January 18, 2024 20:28
@vivek-koppuruvivek-koppuru
opened #7327
vivek-koppuru:inplace-controllers
Status Failure
Total duration 1m 26s
Artifacts –

golangci-lint.yml

on: pull_request
lint
1m 17s
lint
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 4 warnings
lint: controllers/machinedeployment_inplaceupgrade_controller.go#L59
cyclomatic complexity 11 of func `(*MachineDeploymentInPlaceUpgradeReconciler).Reconcile` is high (> 10) (gocyclo)
lint: controllers/kubeadmcontrolplane_inplaceupgrade_controller.go#L60
cyclomatic complexity 11 of func `(*KubeadmControlPlaneInPlaceUpgradeReconciler).Reconcile` is high (> 10) (gocyclo)
lint
issues found
lint: controllers/kubeadmcontrolplane_inplaceupgrade_controller.go#L48
exported: comment on exported function NewKubeadmControlPlaneInPlaceUpgradeReconciler should be of the form "NewKubeadmControlPlaneInPlaceUpgradeReconciler ..." (revive)
lint: controllers/machinedeployment_inplaceupgrade_controller.go#L47
exported: comment on exported function NewMachineDeploymentInPlaceUpgradeReconciler should be of the form "NewMachineDeploymentInPlaceUpgradeReconciler ..." (revive)
lint: controllers/factory.go#L595
exported: comment on exported method Factory.WithKubeadmControlPlaneInPlaceUpgradeReconciler should be of the form "WithKubeadmControlPlaneInPlaceUpgradeReconciler ..." (revive)
lint: controllers/factory.go#L612
exported: comment on exported method Factory.WithMachineDeploymentInPlaceUpgradeReconciler should be of the form "WithMachineDeploymentInPlaceUpgradeReconciler ..." (revive)