Kindless upgrade changes for vSphere & CloudStack provider #6728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/L
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6728 +/- ##
=======================================
Coverage 75.66% 75.66%
=======================================
Files 475 475
Lines 38359 38404 +45
=======================================
+ Hits 29023 29059 +36
- Misses 7727 7733 +6
- Partials 1609 1612 +3
☔ View full report in Codecov by Sentry. |
g-gaston
reviewed
Sep 25, 2023
panktishah26
force-pushed
the
etcd-controlplaneready-controller
branch
2 times, most recently
from
ea93006 to
cbc23ef
Compare
panktishah26
commented
Sep 26, 2023
| @@ -135,6 +136,9 @@ func (v *Validator) ValidateClusterMachineConfigs(ctx context.Context, clusterSp | |||
| if err := v.validateMachineConfig(ctx, clusterSpec.CloudStackDatacenter, machineConfig); err != nil { | |||
| return fmt.Errorf("machine config %s validation failed: %v", machineConfig.Name, err) | |||
| } | |||
| if err := v.validateTemplateMatchesKubernetesVersion(ctx, machineConfig, clusterSpec); err != nil { | |||
There was a problem hiding this comment.
I had to split validateTemplateMatchesKubernetesVersion method separately to avoid cyclomatic complexity error.
panktishah26
force-pushed
the
etcd-controlplaneready-controller
branch
from
cbc23ef to
cc825dd
Compare
g-gaston
reviewed
Sep 26, 2023
… controller side and waits for both to match for further reconciliation. 2. Since we have seperated ETCD and CP reconciliation, it waits for ETCD to be ready before marking ControlPlaneReady to true. 3. From the CLI side during management cluster upgrade, waits for Cluster FailureMessage to be nil before waiting for other condition to met.
panktishah26
force-pushed
the
etcd-controlplaneready-controller
branch
from
cc825dd to
439e7a3
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR includes fixes for below 3 issues,
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.