-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SAW proofs for integration of Arm proofs for SHA384 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pennyannn
force-pushed
the
yppe/arm-integration-saw
branch
11 times, most recently
from
November 30, 2023 20:26
2ea23fa
to
dd5724f
Compare
pennyannn
force-pushed
the
yppe/arm-integration-saw
branch
3 times, most recently
from
November 30, 2023 20:59
9436a9c
to
dd0325f
Compare
pennyannn
requested review from
apetcher-amazon and
andrewhop
as code owners
November 30, 2023 21:03
pennyannn
force-pushed
the
yppe/arm-integration-saw
branch
6 times, most recently
from
December 1, 2023 01:50
31cf9a1
to
e3e9eb5
Compare
pennyannn
force-pushed
the
yppe/arm-integration-saw
branch
3 times, most recently
from
December 1, 2023 22:41
fd357ac
to
5bdbff6
Compare
pennyannn
force-pushed
the
yppe/arm-integration-saw
branch
2 times, most recently
from
December 1, 2023 23:55
be02daa
to
dc37624
Compare
pennyannn
force-pushed
the
yppe/arm-integration-saw
branch
from
December 2, 2023 01:16
dc37624
to
8de78d9
Compare
apetcher-amazon
suggested changes
Dec 4, 2023
pennyannn
force-pushed
the
yppe/arm-integration-saw
branch
16 times, most recently
from
December 4, 2023 18:50
6dd240c
to
6724bc9
Compare
pennyannn
force-pushed
the
yppe/arm-integration-saw
branch
from
December 4, 2023 19:01
6724bc9
to
0d2904c
Compare
apetcher-amazon
suggested changes
Dec 4, 2023
pennyannn
force-pushed
the
yppe/arm-integration-saw
branch
from
December 5, 2023 01:15
b52883b
to
27aeac8
Compare
apetcher-amazon
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends existing SHA384/512 proofs to support Arm LLVM IR. This work fulfills the integration of Arm assembly proofs in #122 .
Specifically, this PR:
SAW_aarch64
that compiles aws-lc to AArch64 LLVM IR and run SHA384 proofs with the AAarch64 LLVM IRBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.