Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kubectl matching with cluster's version #329

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

unexge
Copy link
Contributor

@unexge unexge commented Jan 2, 2025

Currently, we use stable version of kubectl (v1.32 as of today), and that might cause some problems as kubectl emits a warning:

WARNING: version difference between client (1.32) and server (1.29) exceeds the supported minor version skew of +/-1


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@unexge
Copy link
Contributor Author

unexge commented Jan 2, 2025

This PR also had this change originally:

Increase assume role duration to 75 minutes in end-to-end tests - Our assume role duration in our CI is 1 hour by default, but with the recent changes, our end-to-end test job started taking more than 1 hour sometimes, and that causes our CI to fail due to expired credentials.

But I'll move this change to a different PR as it requires some additional changes on the CI infra.

@unexge unexge changed the title Small CI improvements Use kubectl matching with cluster's version Jan 2, 2025
@unexge unexge force-pushed the unexge/ci-improvements branch from b5180f9 to c2191ed Compare January 2, 2025 13:08
Copy link
Contributor

@jiaeenie jiaeenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @unexge, looks good to me!

@unexge unexge merged commit ee7f1ed into main Jan 2, 2025
21 checks passed
@unexge unexge deleted the unexge/ci-improvements branch January 2, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants