fix: don't respect cargo-dist's install hints for curl-sh exprs #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB when generating Github Release Bodies cargo-dist refines the dist-manifest with the info from create-release endpoint, so even cargo-dist knows that what it uploaded is subpar. The only way for it to upload the right thing is for create-artifact-set to return a "hint" for what the URL would be if we did make a release. ...but that still wouldn't be totally correct for an install-widget for a hypothetical Release Preview, so really we should just stop considering cargo-dist authoritative on the Best Value for these exprs. |
The dist-manifest.json fundamentally lacks the information to generate perfect pretty curl-sh exprs, because it needs to be uploaded before the create-release endpoint tells us this url format. As such, oranda should ignore the manifest for these install-hints, and instead use the inference backend for them, which can use the URLs returned by the list-releases endpoint (or the github release's base url).
Gankra
force-pushed
the
ignore-script-hints
branch
from
dde6b34
to
60ab1fd
Compare
shadows-withal
approved these changes
Dec 20, 2023
|
@Gankra would you say this is worthy of a patch release? |
|
yes, I don't want axo releases to be used with the current behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dist-manifest.json fundamentally lacks the information to generate perfect pretty curl-sh exprs, because it needs to be uploaded before the create-release endpoint tells us this url format. As such, oranda should ignore the manifest for these install-hints, and instead use the inference backend for them, which can use the URLs returned by the list-releases endpoint (or the github release's base url).