Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Multiply Operator (*) overload with tests #59

Merged
merged 11 commits into from
Oct 22, 2020
Merged

Feat: Multiply Operator (*) overload with tests #59

merged 11 commits into from
Oct 22, 2020

Conversation

HashirGJ8842
Copy link
Contributor

@HashirGJ8842 HashirGJ8842 commented Oct 21, 2020 •
edited
Loading

Description of Change

Multiplication operator ( * ) overloaded for largeInt * largeInt

Checklist

  • Added description of change
  • Proper file name given
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Repository owner deleted a comment from HashirGJ8842 Oct 21, 2020
ayaankhan98
ayaankhan98 approved these changes Oct 22, 2020
View reviewed changes
Copy link
Owner

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ayaankhan98 ayaankhan98 merged commit cf587ba into ayaankhan98:main Oct 22, 2020
@ayaankhan98 ayaankhan98 changed the title Feat: * overload with tests Feat: Multiply Operator (*) overload with tests Oct 22, 2020
@ayaankhan98 ayaankhan98 linked an issue Oct 22, 2020 that may be closed by this pull request
[feat] operator overloads #4
Open
17 tasks
ayaankhan98
ayaankhan98 reviewed Oct 22, 2020
View reviewed changes
big-int/src/operators/multiply.cpp

namespace libbig
{
largeInt largeInt::operator*(const largeInt &next_number) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still two overloads are missing.
for largeInt * int and largeInt * int64_t (int64_t aka long long)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayaankhan98 ayaankhan98 ayaankhan98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] operator overloads
2 participants
@HashirGJ8842 @ayaankhan98