[Test Case]: Alignment Curves #22
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergejMuhic
added
documentation
SergejMuhic
requested review from
larswik,
czapplitec,
pjanck,
AlexBrad1eyCT and
JuhaHy
pjanck
reviewed
Jan 10, 2022
| - Linear | ||
|
|
||
| The valid geometry segment types for vertical: | ||
| - Arc |
There was a problem hiding this comment.
Suggested change
| - Arc | |
| - Circular Arc |
More specific more better.
There was a problem hiding this comment.
Leaving as Arc for now. Has to be changed in the partial template name also.
Probably wrong placement of these though.
larswik
reviewed
Mar 15, 2022
| - *IfcAxis2PlacementLinear* | ||
| - *IfcAxis2Placement2D* | ||
| - *IfcAxis2Placement3D* | ||
| - *IfcCircle* |
There was a problem hiding this comment.
How do we handle the cases in ALIN where we have no requirements for geometry at all (only layout)? Can we split this in two (with/without geometry)?
|
|
||
| - *Alignment Layout* | ||
| - *Alignment Geometry* | ||
| - *Alignment Geometry Gradient* |
There was a problem hiding this comment.
Same comment as above. Split in two TIs (with/without geometry)?
| <details><summary>Semantic Usages, Constraints & Logic</summary> | ||
|
|
||
| The following itemised Usages, Constraints & Logic are normative entries within the AbRV MVD and MUST be satisfied to meet the defined validation criteria | ||
|
|
There was a problem hiding this comment.
To me it's a little unclear what exactly to write in this section and what to put in validation criteria below => Discussion!
|
|
||
| ## Validation criteria | ||
| :zap: For this test case to be considered passed **all capabilities** listed in this section shall be verified, with no exception. :zap: | ||
|
|
There was a problem hiding this comment.
I guess this needs to be added...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Outline of the content and tasks addressed by this pull request, dont forget to link the relevent issue(s)
Purpose
Please mark the relevent tasks that this pull request creates or updates:
Resolves #4
Adding test instruction first stage documentation for
[Test Case]: Alignment CurvesTest Cases