Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Case]: Alignment Curves #22

Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions E1-ALRF/ALIG/Dataset/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
## Variations
The Following occurence variations need to be checked and certified in relation to the targetted entities and concept templates:

- Entity_01 - IfcAlignment
- Entity_02 - IfcAlignmentHorizontal
- Entity_03 - IfcAlignmentVertical
- Entity_04 - IfcAlignmentSegment
- Entity_05 - IfcAlignmentHorizontalSegment
- Entity_06 - IfcAlignmentVerticalSegment




## Model Dataset
This test case utilises the attached dataset documented by the following drawings and data schedule.

*This is a later step tha involved the detailed documentation of the certification dataset (model)*


## Drawings (Visualisations)
The following Drawings and visualisations describe the test case dataset to be modelled and certified.


## Supporting files

| Filename | Description |
|-----------------------------------|-------------------------------------------|
| *filename* | *short description* |
177 changes: 177 additions & 0 deletions E1-ALRF/ALIG/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,177 @@
# Test Instructions

| Documentation Code | Title | Exchange Code | Test Code | Author | Data Owner | Version | Date |
|----------------------|------------------------------------------------|---------------|-----------| ----------------|------------|---------|------------|
| IFC4.3AbRV_E1-ALRF_ALIG | Alignment Curves | E1-ALRF | ALIG | Sergej Muhic | Let's see | 1.0 | DD.MM.YYYY |


## Summary

*Include a short description of the test case.*

*Optional: if your data comes from a specific Storyline or unit test of the IFC Infrastructure Deployment Project or IFC Rail Project, please include a link to the originating documentation here. so additional background information can be created.*

With these instructions the baseline alignment exchange will be established between various domains. This includes basic alignment geometry featuring the common layout:
- horizontal
- vertical

The valid geometry segment types for horizontal are the following:
- Arc
- Clothoid
- Cubic (? has to be covered somewhere)
- Linear

The valid geometry segment types for vertical:
- Arc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Arc
- Circular Arc

More specific more better.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving as Arc for now. Has to be changed in the partial template name also.

- Linear
- Parabolic (?does Road use it?)

This test case addresses the import and export of *&&&&* entities within the *&&&* use case for the exchange of *&&&* information...

...


The [Expected Results](#Expected-Results) section lists the material that will be used to assess the fulfilment of capabilities.

:zap: **This is a test-driven process: refer to the [Validation Criteria](#Validation-Criteria) to understand what is required by the test** :zap:

## Itemised Roots
The Test instruction addresses the import and export of the following IFC Entities & Concept Templates:

<details><summary>IFC Entities</summary>

These entities represent a test-specific subset of the wider AbRV_Ex exchange and the overall AbRV MVD. **The scope of the test shall not be used as a definitive scope of the exchange, or of the entire MVD.**

- *IfcAlignment*
- *IfcAlignmnetHorizontal*
- *IfcAlignmentVertical*
- *IfcAlignmentSegment*
- *IfcAlignmentHorizontalSegment*
- *IfcAlignmentVerticalSegment*
- *IfcAxis2PlacementLinear*
- *IfcAxis2Placement2D*
- *IfcAxis2Placement3D*
- *IfcCircle*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we handle the cases in ALIN where we have no requirements for geometry at all (only layout)? Can we split this in two (with/without geometry)?

- *IfcClothoid*
- *IfcCompositeCurve*
- *IfcCurveSegment*
- *IfcLine*
- *IfcLinearPlacement*
- *IfcLocalPlacement*
- *IfcGeometricRepresentationContext*
- *IfcGeometricRepresentationSubContext*
- *IfcGradientCurve*
- *IfcMapConversion*
- *IfcPolyline*
- *IfcProject*
- *IfcProjectedCRS*
- *IfcProductDefinitionShape*
- *IfcSite*
- *IfcShapeRepresentation*

</details>

<details><summary>Concept Templates</summary>

These concept templates represent a test-specific subset of the wider AbRV_Ex exchange and the overall AbRV MVD, that must be correctly exported to meet the validation criteria. **The scope of the test shall not be used as a definitive scope of the exchange, or of the entire MVD.**

- *Alignment Layout*
- *Alignment Geometry*
- *Alignment Geometry Gradient*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above. Split in two TIs (with/without geometry)?

- *Project Global Positioning*
- *Spatial Containment*

</details>

## Test Case Imports
Test instructions are defined with a modular approach to reduce repetition of validation criteria and test content, and improve vendors ability to solve issues and bugs. therefore this test instruction *imports/reuses* the following Test instructions and entities with the relevant associated validation criteria.

:construction: under construction :construction:

<details><summary>Imports & Reuses</summary>

| TI Code | Test Instruction Title | Comments |
|------------------------------------------|---------------------------|------------------------------|
| [IFC4.3AbRV_E0_MSTP](../../E0-SCFD/MSTP) | None? | |

</details>

## Usages, Constraints & Logic
The following itemised restrictions and constraints shall be placed on IFC Entities & Concept Templates:

:construction: under construction :construction:

<details><summary>Semantic Usages, Constraints & Logic</summary>

The following itemised Usages, Constraints & Logic are normative entries within the AbRV MVD and MUST be satisfied to meet the defined validation criteria

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it's a little unclear what exactly to write in this section and what to put in validation criteria below => Discussion!

- IfcCompositeCurve
- Segments of type:
- IfcCurveSegment
- IfcCurveSegment
- ParentCurve of type:
- IfcLine
- IfcPolyline
- IfcCircle
- IfcClothoid
- IfcPolyonomialCurve

</details>

<details><summary>Model Geometry</summary>
The Test case requires the following additional checks related to Model Geometry:

- *Constraint*

</details>

## Expected Results

For certification of capabilities the only source will be:

:construction: under construction :construction:

- n. 1 IFC file containing the information as requested. The file shall be named using the following syntax: `MVDCode`-`ExchangeCode`-`TestCode`-`SoftwareVendor`.`ifc` (Example: `IFC4.3_AbRV-E2b-ASTPC-AmazingSoft.ifc`)

Considering the aim of this test, other **optional** results, not subject to the bSI certification process, yet usefull to illustrate test results are:
- Screen-shot of ...
- CSV export of ...

---

## Validation criteria
:zap: For this test case to be considered passed **all capabilities** listed in this section shall be verified, with no exception. :zap:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this needs to be added...

:construction: under construction :construction:

### General & Imports

<details><summary>Click to expand</summary>

- All the concept templates must be correctly implemented as presented in the validation criteria
- At least 1 instance of each entity listed in [Itemised Roots](#Itemised-Roots) is present in the file.


#### Imports
| **TI Code** | **Criteria Codes** | *COMMENT** |
|--------------------|--------------------|----------------------------------------------------|
| IFC4.3AbRV_E0_MSTP | ALL CRITERIA | As outlined in the dataset [Imported Entities Table](Dataset/README.md#Imported-Entities-Table) |


#### General
| **ID** | **CRITERIA** | **VALUE** | **COMMENT** |
|---------|-----------------------------------------------------|-----------------------------------------------|-------------|
| GENE_01 | All requested entities are present in the IFC model | per [Entities Table](Dataset/README.md#Entities-Table) | |

</details>

### Some Concept Group

<details><summary>Click to expand</summary>
Criteria around the representation of 'Some Concept'

| **ID** | **CRITERIA** | **VALUE** | **COMMENT** |
|---------|-----------------------------------------------------|------------------------------------------|-------------|
| XXXX_01 | A Criteria to follow | its expected value or outcome | |

</details>
6 changes: 3 additions & 3 deletions E1-ALRF/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ TBC

## Test Instructions

| TI Code | Test Instruction Title |
|TI Code| Test Instruction Title|
|-----------------------------------|-------------------------------------------|
| [**IFC4x3_AbRV-E1-ALIG**](./ALIG) | Alignment Curves |
| [**IFC4x3_AbRV-E1-ALLP**](./ALLP) | Alignment Linear Positioning & Stationing |
|[**IFC4x3_AbRV-E1-ALIG**](./ALIG) | Alignment Curves|
|[**IFC4x3_AbRV-E1-ALLP**](./ALLP) | Alignment Linear Positioning & Stationing|