Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Case]: Alignment Linear Positioning & Stationing #23

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

SergejMuhic
Copy link
Collaborator

Summary

Outline of the content and tasks addressed by this pull request, dont forget to link the relevent issue(s)

Purpose

Please mark the relevent tasks that this pull request creates or updates:
Resolves #7

Test Cases

  • Creation of new test case
  • Test case summary
  • Itemised roots & test case imports
  • Usages, constraints & logic
  • Validation criteria & Results
  • Dataset Content & Documentation

@SergejMuhic SergejMuhic added documentation Improvements or additions to documentation test case issues & pull requests relating to test cases labels Jan 5, 2022
@SergejMuhic SergejMuhic self-assigned this Jan 5, 2022
Copy link
Member

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start!

E1-ALRF/ALLP/README.md Outdated Show resolved Hide resolved
- horizontal
- vertical

and the stationing and relative positioning concepts where physical elements can be placed relative to positioning elements. In order to accomplish a semantic description of a station, property sets will be used on referents.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't list Property sets (neither entities nor concepts) in the itemized roots section.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you see a placeholder for that? I did not see it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant IfcPropertySet and IfcSingleProperty (or similar) in the Itemized Roots section of the document.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure honestly. Were these supposed to be added? 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says above:

property sets will be used on referents

That is the reason for my question. I'm not sure if these are supposed to be added.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In "my" TIs, I listed e.g. IfcPropertySet, IfcPropertySingleValue under "Itemised roots/IFC Entities" and e.g. Property Sets For Objects under "Itemised roots/Concept templates".

Copy link
Member

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good.

@@ -0,0 +1,26 @@
## Variations
The Following occurence variations need to be checked and certified in relation to the targetted entities and concept templates:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Following occurence variations need to be checked and certified in relation to the targetted entities and concept templates:
The Following occurence variations need to be checked and certified in relation to the targeted entities and concept templates:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


- Entity_01 - IfcReferent/REFERENCEMARKER
- Entity_02 - IfcReferent/STATION
- Entity_03 - IfcReferent/POSITION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is IfcReferent/POSITION still in?

This test case utilises the attached dataset documented by the following drawings and data schedule.

*This is a later step tha involved the detailed documentation of the certification dataset (model)*

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will need to be added.


## Drawings (Visualisations)
The following Drawings and visualisations describe the test case dataset to be modelled and certified.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follows content in "Model dataset"


| Filename | Description |
|-----------------------------------|-------------------------------------------|
| *filename* | *short description* |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follows content in "Model dataset"

- *IfcRelPositions*
- *IfcSite*
- *IfcShapeRepresentation*

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IfcPropertySet, IfcpropertySingleValue here?

- *Alignment Geometry Gradient*
- *Project Global Positioning*
- *Spatial Containment*

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property Sets for Objects here?

</details>

## Usages, Constraints & Logic
The following itemised restrictions and constraints shall be placed on IFC Entities & Concept Templates:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What to write here and what to write under "Validation Criteria" needs to be clarified => Discussion!

Considering the aim of this test, other **optional** results, not subject to the bSI certification process, yet usefull to illustrate test results are:
- Screen-shot of ...
- CSV export of ...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete :-)

---

## Validation criteria
:zap: For this test case to be considered passed **all capabilities** listed in this section shall be verified, with no exception. :zap:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment regarding this section vs "Usages..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test case issues & pull requests relating to test cases
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[Test Case]: Alignment Linear Positioning & Stationing
4 participants