Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Case]: Alignment Linear Positioning & Stationing #23

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions E1-ALRF/ALLP/Dataset/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
## Variations
The Following occurence variations need to be checked and certified in relation to the targetted entities and concept templates:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Following occurence variations need to be checked and certified in relation to the targetted entities and concept templates:
The Following occurence variations need to be checked and certified in relation to the targeted entities and concept templates:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


- Entity_01 - IfcReferent/REFERENCEMARKER
- Entity_02 - IfcReferent/STATION
- Entity_03 - IfcReferent/POSITION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is IfcReferent/POSITION still in?






## Model Dataset
This test case utilises the attached dataset documented by the following drawings and data schedule.

*This is a later step tha involved the detailed documentation of the certification dataset (model)*

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will need to be added.


## Drawings (Visualisations)
The following Drawings and visualisations describe the test case dataset to be modelled and certified.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follows content in "Model dataset"


## Supporting files

| Filename | Description |
|-----------------------------------|-------------------------------------------|
| *filename* | *short description* |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follows content in "Model dataset"

167 changes: 167 additions & 0 deletions E1-ALRF/ALLP/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,167 @@
# Test Instruction Template

| Documentation Code | Title | Exchange Code | Test Code | Author | Data Owner | Version | Date |
|----------------------|------------------------------------------------|---------------|-----------| ----------------|------------|---------|------------|
| IFC4.3AbRV_E1-ALRF_ALLP | Test Instruction Template | E1-ALRF | ALLP | Sergej Muhic | TBD | 1.0 | DD.MM.YYYY |


## Summary

*Include a short description of the test case.*

*Optional: if your data comes from a specific Storyline or unit test of the IFC Infrastructure Deployment Project or IFC Rail Project, please include a link to the originating documentation here. so additional background information can be created.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove at some point.


With these instructions the baseline stationing and linear positioning exchange will be established between various domains. This includes basic alignment featuring the common layout described in TC1.1:
- horizontal
- vertical

and the stationing and relative positioning concepts where physical elements can be placed relative to positioning elements. In order to accomplish a semantic description of a station, property sets will be used on referents.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't list Property sets (neither entities nor concepts) in the itemized roots section.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you see a placeholder for that? I did not see it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant IfcPropertySet and IfcSingleProperty (or similar) in the Itemized Roots section of the document.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure honestly. Were these supposed to be added? 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says above:

property sets will be used on referents

That is the reason for my question. I'm not sure if these are supposed to be added.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In "my" TIs, I listed e.g. IfcPropertySet, IfcPropertySingleValue under "Itemised roots/IFC Entities" and e.g. Property Sets For Objects under "Itemised roots/Concept templates".


A typical alignment also features reference markers as embedded elements for relative positioning along known locations along the alignment.

This test case addresses the import and export of *&&&&* entities within the *&&&* use case for the exchange of *&&&* information...

...

The [Expected Results](#Expected-Results) section lists the material that will be used to assess the fulfilment of capabilities.

:zap: **This is a test-driven process: refer to the [Validation Criteria](#Validation-Criteria) to understand what is required by the test** :zap:

## Itemised Roots

*This section lists the primary entities and concept templates being validated by this test instruction, these are listed to understand the scope of the data entities being addressed. this is the documentation of the data placed within BIMQ*

The Test instruction addresses the import and export of the following IFC Entities & Concept Templates:

:construction: under construction :construction:

<details><summary>IFC Entities</summary>

These entities represent a test-specific subset of the wider AbRV_Ex exchange and the overall AbRV MVD. **The scope of the test shall not be used as a definitive scope of the exchange, or of the entire MVD.**
- *IfcAlignment*
- *IfcAlignmnetHorizontal*
- *IfcAlignmentVertical*
- *IfcAlignmentSegment*
- *IfcAlignmentHorizontalSegment*
- *IfcAlignmentVerticalSegment*
- *IfcAxis2PlacementLinear*
- *IfcAxis2Placement2D*
- *IfcAxis2Placement3D*
- *IfcCircle*
- *IfcClothoid*
- *IfcCompositeCurve*
- *IfcCurveSegment*
- *IfcLine*
- *IfcLinearPlacement*
- *IfcLocalPlacement*
- *IfcGeometricRepresentationContext*
- *IfcGeometricRepresentationSubContext*
- *IfcGradientCurve*
- *IfcMapConversion*
- *IfcPolyline*
- *IfcProject*
- *IfcProjectedCRS*
- *IfcProductDefinitionShape*
- *IfcReferent*
- *IfcRelPositions*
- *IfcSite*
- *IfcShapeRepresentation*

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IfcPropertySet, IfcpropertySingleValue here?

</details>

<details><summary>Concept Templates</summary>

These concept templates represent a test-specific subset of the wider AbRV_Ex exchange and the overall AbRV MVD, that must be correctly exported to meet the validation criteria. **The scope of the test shall not be used as a definitive scope of the exchange, or of the entire MVD.**
- *Alignment Layout*
- *Alignment Geometry*
- *Alignment Geometry Gradient*
- *Project Global Positioning*
- *Spatial Containment*

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property Sets for Objects here?

</details>

## Test Case Imports
Test instructions are defined with a modular approach to reduce repetition of validation criteria and test content, and improve vendors ability to solve issues and bugs. therefore this test instruction *imports/reuses* the following Test instructions and entities with the relevant associated validation criteria.

:construction: under construction :construction:

<details><summary>Imports & Reuses</summary>

| TI Code | Test Instruction Title | Comments |
|------------------------------------------|---------------------------|------------------------------|
| [IFC4.3AbRV_E0_MSTP](../../E0-SCFD/MSTP) | Model Setup & Positioning | PROJ-01 imported along with RCTX-01 and associated configuration and history data |
| [IFC4.3AbRV_E1_ALRF](../../E1-ALRF/ALIG) | Alignment Curves | Valid alignment geometry |

</details>

## Usages, Constraints & Logic
The following itemised restrictions and constraints shall be placed on IFC Entities & Concept Templates:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What to write here and what to write under "Validation Criteria" needs to be clarified => Discussion!


:construction: under construction :construction:

<details><summary>Semantic Usages, Constraints & Logic</summary>

The following itemised Usages, Constraints & Logic are normative entries within the AbRV MVD and MUST be satisfied to meet the defined validation criteria

- IfcSomething
- *Constraint*

</details>

<details><summary>Model Geometry</summary>
The Test case requires the following additional checks related to Model Geometry:

- *Constraint*

</details>

## Expected Results

For certification of capabilities the only source will be:

:construction: under construction :construction:

- n. 1 IFC file containing the information as requested. The file shall be named using the following syntax: `MVDCode`-`ExchangeCode`-`TestCode`-`SoftwareVendor`.`ifc` (Example: `IFC4.3_AbRV-E2b-ASTPC-AmazingSoft.ifc`)

Considering the aim of this test, other **optional** results, not subject to the bSI certification process, yet usefull to illustrate test results are:
- Screen-shot of ...
- CSV export of ...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete :-)

---

## Validation criteria
:zap: For this test case to be considered passed **all capabilities** listed in this section shall be verified, with no exception. :zap:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment regarding this section vs "Usages..."


:construction: under construction :construction:

### General & Imports

<details><summary>Click to expand</summary>

- All the concept templates must be correctly implemented as presented in the validation criteria
- At least 1 instance of each entity listed in [Itemised Roots](#Itemised-Roots) is present in the file.


#### Imports
| **TI Code** | **Criteria Codes** | *COMMENT** |
|--------------------|--------------------|----------------------------------------------------|
| IFC4.3AbRV_E0_MSTP | ALL CRITERIA | As outlined in the dataset [Imported Entities Table](Dataset/README.md#Imported-Entities-Table) |


#### General
| **ID** | **CRITERIA** | **VALUE** | **COMMENT** |
|---------|-----------------------------------------------------|-----------------------------------------------|-------------|
| GENE_01 | All requested entities are present in the IFC model | per [Entities Table](Dataset/README.md#Entities-Table) | |

</details>

### Some Concept Group

<details><summary>Click to expand</summary>
Criteria around the representation of 'Some Concept'

| **ID** | **CRITERIA** | **VALUE** | **COMMENT** |
|---------|-----------------------------------------------------|------------------------------------------|-------------|
| XXXX_01 | A Criteria to follow | its expected value or outcome | |

</details>