Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Case]: Alignment Superelevation & Width #25

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

larswik
Copy link
Collaborator

@larswik larswik commented Jan 7, 2022

Summary

Outline of the content and tasks addressed by this pull request, dont forget to link the relevent issue(s)

Purpose

Please mark the relevent tasks that this pull request creates or updates:
Started addressing Issue #9

Exchanges

  • Creation of new exchange
  • Documentation of exchange

Test Cases

  • Creation of new test case
  • Test case summary
  • Itemised roots & test case imports
  • Usages, constraints & logic
  • Validation criteria & Results
  • Dataset Content & Documentation

General

  • CI updates
  • Repository documentation
  • Bug fixes

@larswik larswik added documentation Improvements or additions to documentation test case issues & pull requests relating to test cases labels Jan 7, 2022
@larswik larswik self-assigned this Jan 7, 2022
@larswik larswik requested review from JuhaHy and pjanck January 7, 2022 12:27
Copy link
Member

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress so far!

E1a-ARSE/ALSE/README.md Outdated Show resolved Hide resolved
E1a-ARSE/ALSE/README.md Outdated Show resolved Hide resolved
E1a-ARSE/ALSE/README.md Outdated Show resolved Hide resolved
- **IfcFacilityPart/CARRIAGEWAY**
- **IfcAnnotation/SUPERELEVATIONEVENT (one for every start of alignment element)**
- **Pset_Superelevation (left side)**
- **IfcLinearPlacement**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't think IfcLinearPlacement is unique to this test?

- **IfcAnnotation/SUPERELEVATIONEVENT (one for every start of alignment element)**
- **Pset_Superelevation (right side)**
- **IfcLinearPlacement**
- **IfcAnnotation/WIDTHEVENT (one at start, add a narrowing of the road somewhere along the alignment)**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand the indentations. Are we supposed to do that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I wouldn't say that. This was just for me to sketch a possible structure for the imagined file to export. Indentations are just to i achieve readability (at least for me), similar to Jon's Tree View app.

- *Alignment Geometry Gradient*
- *Product Local Placement*

- For this test instruction:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would expect this one would be inheriting from position stationing. In that case, these two templates would be inherited.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I went by the TI dependencies specified but let's discuss.

@SergejMuhic SergejMuhic marked this pull request as draft January 24, 2022 15:10
Copy link
Member

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good corrections. As this PR is still a draft, I assume more is coming.

@larswik larswik removed the request for review from AlexBrad1eyCT March 11, 2022 16:16
@larswik larswik marked this pull request as ready for review March 11, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test case issues & pull requests relating to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants