Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Case]: Alignment Superelevation & Width #25

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
50 changes: 50 additions & 0 deletions E1a-ARSE/ALSE/Dataset/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
## Variations
The Following occurence variations need to be checked and certified in relation to the targeted entities and concept templates:

- (Entity_01) IfcAnnotation/SUPERELEVATIONEVENT - *Pset_SuperElevation needs all variants of Side and TransitionSuperelevation tested. Furthermore, values for Superelevation shall include both positive and negative values*

- (Entity_02) IfcAnnotation/WIDTHEVENT - *Pset_Width needs all variants of Side and TransitionWidth tested.*

## Model Dataset
This test case utilises the attached dataset documented by the following drawings and data schedule.

"Synopsis" (unique entities for this test in **bold**):

- IfcProject

- IfcGeometricRepresentationContext

- IfcMapConversion
- IfcProjectedCRS

- IfcSite

- IfcAlignment
- Should have straights, clothoid/circular arc to the left and to the right
- Vertical is not really needed but is probably part of the included E1-ALRF

- IfcRoad
- IfcFacilityPart/ROADSEGMENT
- **IfcFacilityPart/CARRIAGEWAY**
- **IfcAnnotation/SUPERELEVATIONEVENT (one for every start of alignment element)**
- **Pset_Superelevation (left side)**
- **IfcLinearPlacement**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't think IfcLinearPlacement is unique to this test?

- **IfcAnnotation/SUPERELEVATIONEVENT (one for every start of alignment element)**
- **Pset_Superelevation (right side)**
- **IfcLinearPlacement**
- **IfcAnnotation/WIDTHEVENT (one at start, add a narrowing of the road somewhere along the alignment)**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand the indentations. Are we supposed to do that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I wouldn't say that. This was just for me to sketch a possible structure for the imagined file to export. Indentations are just to i achieve readability (at least for me), similar to Jon's Tree View app.

- **Pset_Width (both)**
- **IfcLinearPlacement**

*This is a later step tha involved the detailed documentation of the certification dataset (model)*


## Drawings (Visualisations)
The following Drawings and visualisations describe the test case dataset to be modelled and certified.


## Supporting files

| Filename | Description |
|-----------------------------------|-------------------------------------------|
| *filename* | *short description* |
171 changes: 171 additions & 0 deletions E1a-ARSE/ALSE/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,171 @@
# Test Instruction

| Documentation Code | Title | Exchange Code | Test Code | Author | Data Owner | Version | Date |
| ------------------- | -------------------------------- | --------------- | --------- | ------------- | ---------- | ------- | ---------- |
| IFC4.3AbRV_E1a_ALSE | Alignment Superelevation & Width | IFC4x3_AbRV-E1a | ALSE | Lars WIkström | FTIA? | 1.0 | 07.01.2022 |


## Summary (Intent)

This is the test instruction for IFC4x3_AbRV-E1a-ALSE - Alignment Superelevation & Width.

The test instruction includes:

- A basic project structure setup including units and global positioning
- An alignment structure for a road including the horizontal and vertical layouts
- Assignment of superelevation- and width events along the alignment geometry using linear placement marking the locations where these design parameters change and the values of these design parameters

The data comes from, and is a simplified version of, the IFC Infra Unit Test [MCON-2](https://github.com/bSI-InfraRoom/IFC-infra-unit-test/tree/main/MCON-2) which in turn is extracted from the IFC Rail [Level Crossing storyline](https://github.com/IFCRail/IFC-Rail-Unit-Test/tree/master/8_Storylines%20Test%20(SL)/SL08_Level%20Crossing).

...

The [Expected Results](#Expected-Results) section lists the material that will be used to assess the fulfilment of capabilities.

:zap: **This is a test-driven process: refer to the [Validation Criteria](#Validation-Criteria) to understand what is required by the test** :zap:

## Itemised Roots
*This section lists the primary entities and concept templates being validated by this test instruction, these are listed to understand the scope of the data entities being addressed. this is the documentation of the data placed within BIMQ*

The Test instruction addresses the import and export of the following IFC Entities & Concept Templates:

:construction: under construction :construction:

<details><summary>IFC Entities</summary>

These entities represent a test-specific subset of the wider AbRV_Ex exchange and the overall AbRV MVD. **The scope of the test shall not be used as a definitive scope of the exchange, or of the entire MVD.**

- Inherited from impported tests:
pjanck marked this conversation as resolved.
Show resolved Hide resolved
- *IfcProject*
- *IfcSite*
- *IfcRoad*
- *IfcAlignment*
- *IfcAlignmentHorizontal*
- *IfcAlignmentVertical*
- *IfcAlignmentSegment*
- *IfcAlignmentHorizontalSegment*
- *IfcAlignmentVerticalSegment*
- *IfcContext*

- For this test instruction:
- *IfcFacilityPart*
- *IfcAnnotation*
- *IfcPropertySet*
- *IfcPropertySingleValue*
- *IfcPropertyEnumeratedValue*
pjanck marked this conversation as resolved.
Show resolved Hide resolved


</details>

<details><summary>Concept Templates</summary>

These concept templates represent a test-specific subset of the wider AbRV_Ex exchange and the overall AbRV MVD, that must be correctly exported to meet the validation criteria. **The scope of the test shall not be used as a definitive scope of the exchange, or of the entire MVD.**

- Inherited from imported tests:
- *Project Units*
- *Project Representation Context*
- *Project Global Positioning*
- *Spatial Decomposition*
- *Spatial Composition*
- *Spatial Container*
- *Alignment Decomposition*
- *Alignment Geometry Gradient*
- Product Local Placement*
larswik marked this conversation as resolved.
Show resolved Hide resolved

- For this test instruction:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would expect this one would be inheriting from position stationing. In that case, these two templates would be inherited.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I went by the TI dependencies specified but let's discuss.

- *Product Linear Placement*
- *Property Sets for Objects*


</details>

## Test Case Imports
Test instructions are defined with a modular approach to reduce repetition of validation criteria and test content, and improve vendors ability to solve issues and bugs. therefore this test instruction *imports/reuses* the following Test instructions and entities with the relevant associated validation criteria.

:construction: under construction :construction:

<details><summary>Imports & Reuses</summary>

| TI Code | Test Instruction Title | Comments |
| ------------------------------------------------------------ | ------------------------------- | ------------------------------------------------------------ |
| [**IFC4x3_AbRV-E1a-ALIN**](https://github.com/bSI-InfraRoom/MVD-Infra-Test-Instructions/blob/develop/E1a-ARSE/ALIN) | Alignment Infrastructure Curves | Including all dependencies, i.e. E0_SSRD, E0_SSSI and E0_MSTP |

</details>

## Usages, Constraints & Logic
The following itemised restrictions and constraints shall be placed on IFC Entities & Concept Templates:

:construction: under construction :construction:

<details><summary>Semantic Usages, Constraints & Logic</summary>

The following itemised Usages, Constraints & Logic are normative entries within the AbRV MVD and MUST be satisfied to meet the defined validation criteria

- IfcAnnotation/SUPERELEVATIONEVENT
- *Each superelevation event shall have a linear placement relative to the alignment curve according to CT Product Linear Placement*
- *Each superelevation event shall have one instance of Pset_Superelevation attached according to CT Property Sets for Objects*
- *Each instance of Pset_Superelevation shall have values for properties Side, Superelevation and TransitionSuperelevation*

- IfcAnnotation/WIDTHEVENT
- *Each width event shall have a linear placement relative to the alignment curve according to CT Product Linear Placement**
- *Each width event shall have one instance of Pset_Width attached according to CT Property Sets for Objects**
- *Each instance of Pset_Superelevation shall have values for properties Side, NominalWidth and TransitionWidth*

</details>

<details><summary>Model Geometry</summary>
The Test case requires the following additional checks related to Model Geometry:

- *Constraint*

</details>

## Expected Results

For certification of capabilities the only source will be:

:construction: under construction :construction:

- n. 1 IFC file containing the information as requested. The file shall be named using the following syntax: `MVDCode`-`ExchangeCode`-`TestCode`-`SoftwareVendor`.`ifc` (Example: `IFC4.3_AbRV-E2b-ASTPC-AmazingSoft.ifc`)

Considering the aim of this test, other **optional** results, not subject to the bSI certification process, yet usefull to illustrate test results are:
- Screen-shot of ...
- CSV export of ...

---

## Validation criteria
:zap: For this test case to be considered passed **all capabilities** listed in this section shall be verified, with no exception. :zap:

:construction: under construction :construction:

### General & Imports

<details><summary>Click to expand</summary>

- All the concept templates must be correctly implemented as presented in the validation criteria
- At least 1 instance of each entity listed in [Itemised Roots](#Itemised-Roots) is present in the file.


#### Imports
| **TI Code** | **Criteria Codes** | *COMMENT** |
|--------------------|--------------------|----------------------------------------------------|
| IFC4.3AbRV_E0_MSTP | ALL CRITERIA | As outlined in the dataset [Imported Entities Table](Dataset/README.md#Imported-Entities-Table) |


#### General
| **ID** | **CRITERIA** | **VALUE** | **COMMENT** |
|---------|-----------------------------------------------------|-----------------------------------------------|-------------|
| GENE_01 | All requested entities are present in the IFC model | per [Entities Table](Dataset/README.md#Entities-Table) | |

</details>

### Some Concept Group

<details><summary>Click to expand</summary>
Criteria around the representation of 'Some Concept'

| **ID** | **CRITERIA** | **VALUE** | **COMMENT** |
|---------|-----------------------------------------------------|------------------------------------------|-------------|
| XXXX_01 | A Criteria to follow | its expected value or outcome | |

</details>