Support Instead of Trigger On Views #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
deepakshi-mittal
force-pushed
the
BABEL-2170-v2
branch
from
fc8ac98 to
eedbca5
Compare
deepakshi-mittal
requested review from
rishabhtanwar29,
2jungkook,
xhfanhe and
forestkeeper
deepakshi-mittal
force-pushed
the
BABEL-2170-v2
branch
from
f8f2e48 to
f016738
Compare
xhfanhe
reviewed
Dec 28, 2023
deepakshi-mittal
force-pushed
the
BABEL-2170-v2
branch
from
82b8dfb to
ecb21c5
Compare
xhfanhe
reviewed
Dec 29, 2023
Currently Postgres does not support Instead of Trigger On Views for DML queries. On running such a query on VIEW, query rewriting substitutes view with underlying base table. Added a hook for skipping the substitution for DML query on the VIEW. This change will add support for Instead of Triggers for DML queries when using Babelfish. Task: BABEL-2170/BABEL-4532/BABEL-4514 Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Fixed indentation Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
Ignored file containing multi-db test from jdbc schedule. Removed set config change for multi-db Added basic test cases seperately to verify IO Triggers. Task:BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
deepakshi-mittal
force-pushed
the
BABEL-2170-v2
branch
from
ecb21c5 to
1aa495b
Compare
forestkeeper
reviewed
Jan 2, 2024
forestkeeper
reviewed
Jan 2, 2024
deepakshi-mittal
force-pushed
the
BABEL-2170-v2
branch
from
1aa495b to
9e30f51
Compare
Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
deepakshi-mittal
force-pushed
the
BABEL-2170-v2
branch
from
9e30f51 to
d3fc730
Compare
forestkeeper
approved these changes
Jan 3, 2024
forestkeeper
merged commit 2273124
into
babelfish-for-postgresql:BABEL_3_X_DEV
30 checks passed
deepakshi-mittal
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 3, 2024
Currently Postgres does not support Instead of Trigger On Views for DML queries. On running such a query on VIEW, query rewriting substitutes view with underlying base table. Added a hook for skipping the substitution for DML query on the VIEW. This change will add support for Instead of Triggers for DML queries when using Babelfish. Task: BABEL-2170/BABEL-4532/BABEL-4514 Signed-off-by: Deepakshi Mittal <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently Postgres does not support Instead of Trigger On Views for DML queries.
On running such a query on VIEW, query rewriting substitutes view with underlying base table.
Added a hook for skipping the substitution for DML query on the VIEW.
This change will add support for Instead of Triggers for DML queries when using Babelfish.
Task: BABEL-2170/BABEL-4532/BABEL-4514
Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#272
Issues Resolved
BABEL-2170/BABEL-4532/BABEL-4514
Test Scenarios Covered
Instead of Trigger (IOT) on View for Insert/Update/Delete queries
Transition tables inside IOT on View
IOT calling itself. IOT A <-> IOT A
IOT A <-> IOT B
IOT with transition tables
IOT Cross database
IOT Cross Schema
IOT for Transaction, Commit, Rollback, Rollback to Savepoint
IOT for Bulk insert
Same name trigger not allowed for View/Table
DROP Trigger cross Schema
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.