-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed blankspace padding in char datatype for multibyte characters #2167
Merged
Deepesh125
merged 4 commits into
babelfish-for-postgresql:BABEL_3_X_DEV
from
rohit01010:BABEL-4638
Jan 8, 2024
Merged
Fixed blankspace padding in char datatype for multibyte characters #2167
Deepesh125
merged 4 commits into
babelfish-for-postgresql:BABEL_3_X_DEV
from
rohit01010:BABEL-4638
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Bhagat <[email protected]>
Deepesh125
requested changes
Dec 25, 2023
Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Signed-off-by: Rohit Bhagat <[email protected]>
Deepesh125
approved these changes
Jan 8, 2024
Deepesh125
merged commit Jan 8, 2024
217bd56
into
babelfish-for-postgresql:BABEL_3_X_DEV
30 checks passed
rohit01010
added a commit
to rohit01010/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…abelfish-for-postgresql#2167) Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue. Task: BABEL-4638 Signed-off-by: Rohit Bhagat <[email protected]>
1 task
rohit01010
added a commit
to rohit01010/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…abelfish-for-postgresql#2167) Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue. Task: BABEL-4638 Signed-off-by: Rohit Bhagat <[email protected]>
1 task
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…abelfish-for-postgresql#2167) Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue. Task: BABEL-4638 Signed-off-by: Rohit Bhagat <[email protected]>
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…abelfish-for-postgresql#2167) Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue. Task: BABEL-4638 Signed-off-by: Rohit Bhagat <[email protected]>
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…abelfish-for-postgresql#2167) Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue. Task: BABEL-4638 Signed-off-by: Rohit Bhagat <[email protected]>
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…abelfish-for-postgresql#2167) Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue. Task: BABEL-4638 Signed-off-by: Rohit Bhagat <[email protected]>
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…abelfish-for-postgresql#2167) Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue. Task: BABEL-4638 Signed-off-by: Rohit Bhagat <[email protected]>
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…abelfish-for-postgresql#2167) Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue. Task: BABEL-4638 Signed-off-by: Rohit Bhagat <[email protected]>
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…abelfish-for-postgresql#2167) Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue. Task: BABEL-4638 Signed-off-by: Rohit Bhagat <[email protected]>
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…abelfish-for-postgresql#2167) Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue. Task: BABEL-4638 Signed-off-by: Rohit Bhagat <[email protected]>
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…abelfish-for-postgresql#2167) Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue. Task: BABEL-4638 Signed-off-by: Rohit Bhagat <[email protected]>
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…abelfish-for-postgresql#2167) Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue. Task: BABEL-4638 Signed-off-by: Rohit Bhagat <[email protected]>
rishabhtanwar29
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jan 8, 2024
…abelfish-for-postgresql#2167) Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue. Task: BABEL-4638 Signed-off-by: Rohit Bhagat <[email protected]>
shardgupta
pushed a commit
that referenced
this pull request
Jan 9, 2024
…2167) Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue. Task: BABEL-4638 Signed-off-by: Rohit Bhagat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when multi-byte character is casted to char(1) space padding was not done properly. This PR will fix this issue.
Tested locally
Signed-off-by: Rohit Bhagat [email protected]
Issues Resolved
BABEL-4638
Test Scenarios Covered
Use case based - NA
Boundary conditions - NA
Arbitrary inputs - NA
Negative test cases - NA
Minor version upgrade tests - NA
Major version upgrade tests - NA
Performance tests - NA
Tooling impact - NA
Client tests - NA
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.