Fix alter table drop constraint not able to drop some constraints #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
Signed-off-by: Tanzeel Khan <[email protected]>
tanscorpio7
requested review from
shah-nirmit
and removed request for
shah-nirmit and
KushaalShroff
KushaalShroff
approved these changes
May 21, 2024
shardgupta
merged commit 9727955
into
babelfish-for-postgresql:BABEL_2_X_DEV
29 checks passed
tanscorpio7
added a commit
to tanscorpio7/babelfish_extensions
that referenced
this pull request
May 22, 2024
…belfish-for-postgresql#2575) Babelfish was hashing the constraint name for named table constraints. But no hashing was done for unnamed table constraints, unnamed column constraints or named column constraints. On the other hand the constraint name in DROP CONSTRAINT was always hashed without exception. This means we were failing DROP for all constraints which were not hashed during creation. As a fix, we have removed the hashing step from named table constraints creation, making creation of constraints consistent for babelfish. This also allows us to remove hashing from DROP CONSTRAINT command. Not hashing constraint name has one repercussion, Users can now create a PRIMARY KEY/UNIQUE constraint with same name as an existing Index on the same table. This was previously blocked for named table constraints but not for other types of constraints. We could block this in the future in a more complete way. Issues Resolved: BABEL-2047 Signed-off-by: Tanzeel Khan [email protected]
1 task
tanscorpio7
added a commit
to tanscorpio7/babelfish_extensions
that referenced
this pull request
May 22, 2024
…belfish-for-postgresql#2575) Babelfish was hashing the constraint name for named table constraints. But no hashing was done for unnamed table constraints, unnamed column constraints or named column constraints. On the other hand the constraint name in DROP CONSTRAINT was always hashed without exception. This means we were failing DROP for all constraints which were not hashed during creation. As a fix, we have removed the hashing step from named table constraints creation, making creation of constraints consistent for babelfish. This also allows us to remove hashing from DROP CONSTRAINT command. Not hashing constraint name has one repercussion, Users can now create a PRIMARY KEY/UNIQUE constraint with same name as an existing Index on the same table. This was previously blocked for named table constraints but not for other types of constraints. We could block this in the future in a more complete way. Issues Resolved: BABEL-2047 Signed-off-by: Tanzeel Khan [email protected]
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Babelfish was hashing the constraint name for named table constraints. But no hashing was done for unnamed table constraints, unnamed column constraints or named column constraints. On the other hand the constraint name in DROP CONSTRAINT was always hashed without exception. This means we were failing DROP for all constraints which were not hashed during creation.
As a fix, we have removed the hashing step from named table constraints creation, making creation of constraints consistent for babelfish. This also allows us to remove hashing from DROP CONSTRAINT command.
Not hashing constraint name has one repercussion, Users can now create a PRIMARY KEY/UNIQUE constraint with same name as an existing Index on the same table. This was previously blocked for named table constraints but not for other types of constraints.
We could block this in the future in a more complete way.
Issues Resolved
[BABEL-2047]
Test Scenarios Covered
Sign Off
Signed-off-by: Tanzeel Khan [email protected]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.