Add TDS-specific SSL handshake handling #3261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the TdsSSLHandshake function to handle SSL handshakes specifically for TDS connections. The ProtocolExtensionConfig structure has been updated with a new fn_ssl_handshake function pointer, allowing protocol-specific SSL handling. This change ensures that TDS connections bypass the standard SSL handshake by returning STATUS_OK without invoking ProcessSSLStartup. Task: BABEL-5342 Signed-off-by: Roshan Kanwar <[email protected]>
Merged
1 task
sumitj824
reviewed
Dec 16, 2024
Pull Request Test Coverage Report for Build 12389020093Details
💛 - Coveralls |
sumitj824
approved these changes
Dec 18, 2024
shardgupta
approved these changes
Dec 18, 2024
shardgupta
merged commit 93b91d1
into
babelfish-for-postgresql:BABEL_5_X_DEV
44 checks passed
pranavJ23
pushed a commit
to pranavJ23/babelfish_extensions
that referenced
this pull request
Jan 6, 2025
This commit adds the TdsSSLHandshake function to handle SSL handshakes specifically for TDS connections. The ProtocolExtensionConfig structure has been updated with a new fn_ssl_handshake function pointer, allowing protocol-specific SSL handling. This change ensures that TDS connections bypass the standard SSL handshake by returning STATUS_OK without invoking ProcessSSLStartup. Task: BABEL-5342 Signed-off-by: Roshan Kanwar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds the
TdsDirectSSLHandshakefunction to handle SSL handshakes specifically for TDS connections. TheProtocolExtensionConfigstructure has been updated with a newfn_direct_ssl_handshakefunction pointer, allowing protocol-specific SSL handling. This change ensures that TDS connections bypass the standard SSL handshake by returningSTATUS_OKwithout invokingProcessSSLStartup.Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#501
Issues Resolved
BABEL-5342
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.