Refactor direct SSL handshake logic #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the SSL handshake logic in the engine to support protocol-specific handling through the fn_ssl_handshake function pointer. A wrapper function encapsulates the static ProcessSSLStartup logic for non-TDS connections, ensuring the original functionality is preserved. The connection startup process now delegates SSL handshake handling to the protocol-defined function. Task: BABEL-5342 Signed-off-by: Roshan Kanwar <[email protected]>
1 task
sumitj824
reviewed
Dec 16, 2024
kuntalghosh
previously approved these changes
Dec 18, 2024
sumitj824
approved these changes
Dec 18, 2024
shardgupta
approved these changes
Dec 18, 2024
shardgupta
merged commit fc679ed
into
babelfish-for-postgresql:BABEL_5_X_DEV__PG_17_X
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit refactors the direct SSL handshake logic in the engine to support protocol-specific handling through the
fn_direct_ssl_handshakefunction pointer. Changed the definition ofProcessSSLStartupfunction to non-static for handling non-TDS connections directly frompostmaster.c. The connection startup process now delegates SSL handshake handling to the protocol-defined function.Extension PR: babelfish-for-postgresql/babelfish_extensions#3261
Issues Resolved
BABEL-5342
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.