Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to use newer Java version #3270

Conversation

timchang514
Copy link
Contributor

@timchang514 timchang514 commented Dec 17, 2024

Description

Updating the README to use a newer Java version. The Antlr version update requires Java 8 at minimum to build.

For Ubuntu, I verified the version openjdk-21-jre was available by using a clean Ubuntu install.

For the RHEL version we typically develop on, the default version of Java available is openjdk-17, so that doesn't need changing.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12383505376

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.834%

Totals Coverage Status
Change from base Build 12375848385: 0.0%
Covered Lines: 46606
Relevant Lines: 62279

💛 - Coveralls

@kuntalghosh kuntalghosh merged commit beb4c85 into babelfish-for-postgresql:BABEL_4_X_DEV Dec 18, 2024
47 checks passed
@timchang514 timchang514 deleted the fix-readme-jdk-version branch December 18, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants