Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default as params for function and procedure #242

Conversation

forestkeeper
Copy link
Contributor

Previously when we call functions/procedures, we don't support default keyword usage like :

select foofunc(default);
or
exec fooproc default

This commit support to use default keyword as function or procedure param when the default value is previously defined in create proc/func

Task: BABEL-335

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Previously when we call functions/procedures, we don't support default
keyword usage like :

select foofunc(default);
or
exec fooproc default

This commit support to use default keyword as function or procedure
param when the default value is previously defined in create proc/func

Task: BABEL-335
Signed-off-by: Zhibai Song <[email protected]>
@forestkeeper forestkeeper changed the title Support default as params for function and procedure [Draft] Support default as params for function and procedure Oct 25, 2023
@forestkeeper forestkeeper changed the title [Draft] Support default as params for function and procedure Support default as params for function and procedure Oct 27, 2023
@forestkeeper forestkeeper merged commit 6d935a4 into babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X Oct 28, 2023
2 checks passed
Sairakan pushed a commit to amazon-aurora/postgresql_modified_for_babelfish that referenced this pull request Nov 16, 2023
…ostgresql#242)

* Support default as params for function and procedure

Previously when we call functions/procedures, we don't support default
keyword usage like :

select foofunc(default);
or
exec fooproc default

This commit support to use default keyword as function or procedure
param when the default value is previously defined in create proc/func

Task: BABEL-335
Signed-off-by: Zhibai Song <[email protected]>
priyansx pushed a commit to amazon-aurora/postgresql_modified_for_babelfish that referenced this pull request Nov 22, 2023
…ostgresql#242)

* Support default as params for function and procedure

Previously when we call functions/procedures, we don't support default
keyword usage like :

select foofunc(default);
or
exec fooproc default

This commit support to use default keyword as function or procedure
param when the default value is previously defined in create proc/func

Task: BABEL-335
Signed-off-by: Zhibai Song <[email protected]>
staticlibs pushed a commit to wiltondb/postgresql_modified_for_babelfish that referenced this pull request Jun 23, 2024
…ostgresql#242)

* Support default as params for function and procedure

Previously when we call functions/procedures, we don't support default
keyword usage like :

select foofunc(default);
or
exec fooproc default

This commit support to use default keyword as function or procedure
param when the default value is previously defined in create proc/func

Task: BABEL-335
Signed-off-by: Zhibai Song <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants