Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate to walletconnect v2 using ethereum-provider #3581

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

agualis
Copy link
Collaborator

@agualis agualis commented Jun 26, 2023

Description

This PR prepares the WalletConnect v2 integration to be deployed as a bug fix (expected v1 sunset date is Wed 28).

Walletconnect team confirmed that there are still some issues with Metamask wallet when switching networks. (They are working on that).

Switched walletconnect/web3-provider to walletconnect/ethereum-provider. This is v2 of walletconnect which changes the modal and connection url format.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Visual context

Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@agualis agualis self-assigned this Jun 26, 2023
@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 1:51pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jun 26, 2023 1:51pm

@agualis agualis changed the title Migrate to walletconnect v2 using ethereum-provider feat: Migrate to walletconnect v2 using ethereum-provider Jun 27, 2023
@agualis agualis marked this pull request as ready for review June 28, 2023 07:40
@agualis agualis merged commit 79566c5 into master Jun 28, 2023
4 checks passed
@agualis agualis mentioned this pull request Jun 28, 2023
14 tasks
@agualis agualis deleted the feat/wallet-connect-v2-migration branch June 29, 2023 07:22
@agualis agualis mentioned this pull request Jun 29, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants