try and add an xdef to mimic what go toolset does for testing.Testing… #4096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
paulgmiller
changed the title
fmeum
reviewed
Sep 11, 2024
| @@ -150,7 +150,8 @@ def _go_test_impl(ctx): | |||
| # before user code. See comment above the init function | |||
| # in bzltestutil/init.go. | |||
| test_gc_linkopts.extend(["-X", "+initfirst/github.com/bazelbuild/rules_go/go/tools/bzltestutil/chdir.RunDir=" + run_dir]) | |||
|
|
|||
| #post golang 1.23 testing.Testing is expected to be set for go tests | |||
There was a problem hiding this comment.
Please run buildifier and add a reference to the testing.Testing() function here.
There was a problem hiding this comment.
Thanks going a little slow since I am pretty new to bazel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://pkg.go.dev/testing\#Testing
Go test sets an -X so that code knows if its in a UT
What type of PR is this?
Feature?
What does this PR do? Why is it needed?
Adds an xdef to mimic go test more precisely.
Should we only do for go > 1.23?
Which issues(s) does this PR fix?
Fixes #3686
Other notes for review