Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try and add an xdef to mimic what go toolset does for testing.Testing… #4096

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

try and add an xdef to mimic what go toolset does for testing.Testing… #4096

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0571e73
try and add an xdef to mimic what go toolset toes for testing.Testing…
paulgmiller Sep 10, 2024
907dc64
maybe this is it
paulgmiller Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion go/private/rules/test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ def _go_test_impl(ctx):
# before user code. See comment above the init function
# in bzltestutil/init.go.
test_gc_linkopts.extend(["-X", "+initfirst/github.com/bazelbuild/rules_go/go/tools/bzltestutil/chdir.RunDir=" + run_dir])

#post golang 1.23 testing.Testing is expected to be set for go tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run buildifier and add a reference to the testing.Testing() function here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks going a little slow since I am pretty new to bazel.

test_gc_linkopts.extend(["-X", "testing.Testing=1"])
# Now compile the test binary itself
test_library = GoLibrary(
name = go.label.name + "~testmain",
Expand Down